Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneAPI 2024.1.0 Support, main branch (2024.04.11.) #115

Merged

Conversation

krasznaa
Copy link
Member

As one might guess, #113 and #114 were just collateral updates for this PR. 😛

With oneAPI 2024.1.0 Intel switched to enforcing SYCL 2020 rules more strictly than it did earlier. And as it turns out, using std::abs with floating point numbers is no longer okay in SYCL device code. 🤔 Leading to the following, very non-descriptive linker error:

[build] ptxas fatal   : Unresolved extern function 'fabs'
[build] llvm-foreach: 
[build] ptxas fatal   : Unresolved extern function 'fabsf'
[build] llvm-foreach: 
[build] clang++: error: ptxas command failed with exit code 255 (use -v to see invocation)
[build] Intel(R) oneAPI DPC++/C++ Compiler 2024.1.0 (2024.1.0.20240308)
[build] Target: x86_64-unknown-linux-gnu
[build] Thread model: posix
[build] InstalledDir: /software/intel/oneapi-2024.1.0/compiler/2024.1/bin/compiler
[build] clang++: note: diagnostic msg: Error generating preprocessed source(s).
[build] gmake[2]: *** [tests/accelerator/sycl/CMakeFiles/algebra_test_vecmem_sycl.dir/build.make:93: bin/algebra_test_vecmem_sycl] Error 1
[build] gmake[1]: *** [CMakeFiles/Makefile2:14540: tests/accelerator/sycl/CMakeFiles/algebra_test_vecmem_sycl.dir/all] Error 2

Switching to sycl::fabs solves the issue.

Note that one must not even use sycl::abs on floating point numbers. 😕 So I'll have some further fixes to do in the higher level projects as well... 🤔

Making sure that either std::fabs or sycl::fabs would be used,
as appropriate.
@krasznaa krasznaa added the enhancement New feature or request label Apr 11, 2024
@krasznaa krasznaa merged commit c9b148a into acts-project:main Apr 12, 2024
24 checks passed
@krasznaa krasznaa deleted the oneAPI2024.1Support-main-20240411 branch April 12, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants