CMake Updates, main branch (2024.04.12.) #715
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make fixes similar to acts-project/algebra-plugins#115 for oneAPI 2024.1.0, I wanted to make it more convenient (for me personally...) to build Detray with VSCode. And hence this PR...
-Werror
options in the same way as vecmem and traccc do since a while. I.e. not to activate errors for warnings just in Debug builds, but to activate them using a dedicated CMake cache variable (DETRAY_FAIL_ON_WARNINGS
).Unfortunately this just unleashed a wealth of warnings with oneAPI 2024.1.0. 😦
etc,
Because of this, I didn't activate the new
DETRAY_FAIL_ON_WARNINGS
flag in the presets just yet... 🤔