Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix clang-tidy config file format #4062

Merged
merged 4 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 22 additions & 21 deletions .clang-tidy
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
---
Checks: '-*, \
clang-analyzer-optin.cplusplus.UninitializedObject, \
cppcoreguidelines-init-variables, \
cppcoreguidelines-pro-type-member-init, \
google-readability-casting, \
modernize-concat-nested-namespaces, \
modernize-use-equals-default, \
modernize-use-default-member-init, \
modernize-use-nullptr, \
modernize-use-override, \
modernize-use-using, \
performance-for-range-copy, \
performance-move-const-arg, \
performance-unnecessary-value-param, \
readability-braces-around-statements, \
readability-container-size-empty, \
readability-implicit-bool-cast, \
readability-implicit-bool-conversion, \
readability-inconsistent-declaration-parameter-name, \
readability-named-parameter, \
readability-operators-representation'
Checks: >
-*,
clang-analyzer-optin.cplusplus.UninitializedObject,
cppcoreguidelines-init-variables,
cppcoreguidelines-pro-type-member-init,
google-readability-casting,
modernize-concat-nested-namespaces,
modernize-use-equals-default,
modernize-use-default-member-init,
modernize-use-nullptr,
modernize-use-override,
modernize-use-using,
performance-for-range-copy,
performance-move-const-arg,
performance-unnecessary-value-param,
readability-braces-around-statements,
readability-container-size-empty,
readability-implicit-bool-cast,
readability-implicit-bool-conversion,
readability-inconsistent-declaration-parameter-name,
readability-named-parameter,
readability-operators-representation,
HeaderFilterRegex: '.*(?<!nlohmann\/json)\.(hpp|cpp|ipp)$'
CheckOptions:
readability-operators-representation.BinaryOperators: '&&;&=;&;|;~;!;!=;||;|=;^;^='
Expand Down
39 changes: 1 addition & 38 deletions cmake/ActsStaticAnalysis.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -9,47 +9,10 @@ if(ACTS_RUN_CLANG_TIDY)
else()
message(STATUS "Setting up clang-tidy run")

set(_chks "")
list(APPEND _chks "-*")
list(APPEND _chks "clang-analyzer-optin.cplusplus.UninitializedObject")
list(APPEND _chks "cppcoreguidelines-init-variables")
list(APPEND _chks "cppcoreguidelines-pro-type-member-init")
list(APPEND _chks "google-readability-casting")
list(APPEND _chks "modernize-concat-nested-namespaces")
list(APPEND _chks "modernize-use-equals-default")
list(APPEND _chks "modernize-use-default-member-init")
list(APPEND _chks "modernize-use-nullptr")
list(APPEND _chks "modernize-use-override")
list(APPEND _chks "modernize-use-using")
list(APPEND _chks "performance-for-range-copy")
list(APPEND _chks "performance-move-const-arg")
list(APPEND _chks "performance-unnecessary-value-param")
list(APPEND _chks "readability-braces-around-statements")
list(APPEND _chks "readability-container-size-empty")
list(APPEND _chks "readability-implicit-bool-cast")
list(APPEND _chks "readability-implicit-bool-conversion")
list(APPEND _chks "readability-inconsistent-declaration-parameter-name")
list(APPEND _chks "readability-named-parameter")
list(APPEND _chks "readability-operators-representation")
list(JOIN _chks "," CLANG_TIDY_CHECKS)

message(STATUS "Configured checks")
foreach(_chk ${_chks})
message(STATUS "|-> ${_chk}")
endforeach()

set(_errs "")
list(JOIN _errs "," CLANG_TIDY_ERRORS)

message(STATUS "Enabled errors:")
foreach(_err ${_errs})
message(STATUS "|-> ${_err}")
endforeach()

set(CLANG_TIDY_HEADER_FILTER ".*")

set(CMAKE_CXX_CLANG_TIDY
"${CLANG_TIDY_COMMAND};-checks=${CLANG_TIDY_CHECKS};-header-filter=${CLANG_TIDY_HEADER_FILTER};-warnings-as-errors=${CLANG_TIDY_ERRORS}"
"${CLANG_TIDY_COMMAND};-header-filter=${CLANG_TIDY_HEADER_FILTER};-config-file=${CMAKE_SOURCE_DIR}/.clang-tidy"
)
endif()
endif()
Loading