chore: Fix clang-tidy config file format #4062
Conversation
WalkthroughChanges to static analysis configuration, there are. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
github-actions
bot
added
the
Infrastructure
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
cmake/ActsStaticAnalysis.cmake (1)
15-15: Suggest header filter refinement, I must.Consider restricting header filter pattern more specifically, we should. Currently matches all files with ".*", it does.
Apply this change, you might:
-set(CLANG_TIDY_HEADER_FILTER ".*") +set(CLANG_TIDY_HEADER_FILTER "^.*/(Core|Detector|EventData|Geometry|MagneticField|Material|Propagator|Surfaces|Utilities)/.*\.hpp$")
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
cmake/ActsStaticAnalysis.cmake(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: CI Bridge / linux_ubuntu_2204_clang
- GitHub Check: CI Bridge / linux_ubuntu_2204
- GitHub Check: CI Bridge / build_linux_ubuntu
- GitHub Check: CI Bridge / build_exatrkx
- GitHub Check: CI Bridge / build_exatrkx_cpu
- GitHub Check: CI Bridge / clang_tidy
- GitHub Check: macos
🔇 Additional comments (1)
cmake/ActsStaticAnalysis.cmake (1)
15-15: Approve the simplified configuration approach, I do.Wise decision it is, to move clang-tidy configuration to external file. Cleaner and more maintainable, the code becomes. Standard practice in the industry, this approach is.
Verify the existence of configuration file, we must. Run this command, you shall:
✅ Verification successful
Verified, the configuration file is. Proceed with confidence, you may.
Found and valid, the .clang-tidy file is. In proper YAML format, it exists. Successful, the migration to external configuration has been.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify .clang-tidy file exists and is properly formatted if [ -f ".clang-tidy" ]; then echo "Found .clang-tidy file" # Verify YAML syntax python3 -c 'import yaml, sys; yaml.safe_load(sys.stdin)' < .clang-tidy && echo "YAML syntax valid" else echo "ERROR: .clang-tidy file not found!" exit 1 fiLength of output: 183
|
acts-project-service
added
the
Fails Athena tests
This PR fixes the format of the
.clang-tidyand removes the separate configuration layer that we were using for the CI run of clang-tidy.--- END COMMIT MESSAGE ---
Any further description goes here, @-mentions are ok here!
feat,fix,refactor,docs,choreandbuildtypes.Summary by CodeRabbit
Configuration
.clang-tidyconfiguration to use a more readable multiline format.Maintenance