-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/support arb tokens on coingecko endpoint #1278
Merged
gsteenkamp89
merged 8 commits into
swap-endpoint
from
feat/support-arb-tokens-on-coingecko-endpoint
Nov 22, 2024
Merged
Feat/support arb tokens on coingecko endpoint #1278
gsteenkamp89
merged 8 commits into
swap-endpoint
from
feat/support-arb-tokens-on-coingecko-endpoint
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gsteenkamp89
force-pushed
the
feat/support-arb-tokens-on-coingecko-endpoint
branch
from
November 22, 2024 08:33
340ce15
to
37381f4
Compare
Closed
dohaki
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
gsteenkamp89
deleted the
feat/support-arb-tokens-on-coingecko-endpoint
branch
November 22, 2024 09:46
gsteenkamp89
added a commit
that referenced
this pull request
Nov 29, 2024
* add utility for parsing query params with coercion for non string values * extend api to accept tokenAdress & chainId * bump sdk version * bump sdk, fix build error * small refactor * update sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to ACX-3283