Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/support arb tokens on coingecko endpoint #1278

Merged

Conversation

gsteenkamp89
Copy link
Contributor

@gsteenkamp89 gsteenkamp89 commented Nov 18, 2024

related to ACX-3283

  • allows caller to specify chainId which we'll pass to CG client. CG client is responsible for resolving the platformId based on the chainId. we default to mainnet, as before.

Copy link

linear bot commented Nov 18, 2024

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 🛑 Canceled (Inspect) Nov 22, 2024 8:45am
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 8:45am

@gsteenkamp89 gsteenkamp89 force-pushed the feat/support-arb-tokens-on-coingecko-endpoint branch from 340ce15 to 37381f4 Compare November 22, 2024 08:33
Copy link
Contributor

@dohaki dohaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@gsteenkamp89 gsteenkamp89 merged commit 3efbc6a into swap-endpoint Nov 22, 2024
9 checks passed
@gsteenkamp89 gsteenkamp89 deleted the feat/support-arb-tokens-on-coingecko-endpoint branch November 22, 2024 09:46
gsteenkamp89 added a commit that referenced this pull request Nov 29, 2024
* add utility for parsing query params with coercion for non string values

* extend api to accept tokenAdress & chainId

* bump sdk version

* bump sdk, fix build error

* small refactor

* update sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants