improve: bump sdk #1283
Closed
improve: bump sdk #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mrice32
approved these changes
Nov 22, 2024
james-a-morris
approved these changes
Nov 22, 2024
| @@ -130,7 +130,7 @@ const handler = async ( | |||
| : await coingeckoClient.getCurrentPriceByContract( | |||
| l1Token, | |||
| modifiedBaseCurrency, | |||
| platformId | |||
| Number(platformId) | |||
There was a problem hiding this comment.
This will break.
There are breaking changes made to the coingecko client in the sdk in the latest version.
we address these here and will be merged into master today when swap-endpoint goes in
|
@nicholaspai we can close, redundant after #1298 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE