Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open-api): Fix limits ref #1201

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix(open-api): Fix limits ref #1201

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a98e06
fix(open-api): Fix limits ref
nicholaspai Sep 9, 2024
85b73a8
Update api-docs-openapi.yaml
nicholaspai Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions api-docs-openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,12 @@ paths:
"quoteBlock": "19237525",
"spokePoolAddress": "0xe35e9842fceaCA96570B734083f4a58e8F7C5f2A",
"expectedFillTimeSec": "4",
"limits":
{
"limits": {
"minDeposit": "7799819",
"maxDeposit": "22287428516241",
"maxDepositInstant": "201958902363",
"maxDepositShortDelay": "2045367713809",
"recommendedDepositInstant": "201958902363",
"recommendedDepositInstant": "201958902363"
}
}
"400":
Expand Down Expand Up @@ -531,10 +530,6 @@ components:
description: >
The expected time (in seconds) for a fill to be made. Represents 75th percentile of the 7-day rolling average of times (updated daily). Times are dynamic by origin/destination token/chain for a given amount.
example: "4"
limits:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-a-morris @dohaki any idea how to get this to work? I want to add the TransferLimits schema as the type of limits in the SuggestedFees schema. I was following the guide here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reference this with:

limits:
    $ref: '#/components/schemas/TransferLimits'

type: object
properties:
$ref: '#/components/schemas/TransferLimits'
TransferLimits:
type: object
properties:
Expand Down
Loading