Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(open-api): Fix limits ref #1201

Merged
merged 2 commits into from
Sep 11, 2024
Merged

fix(open-api): Fix limits ref #1201

merged 2 commits into from
Sep 11, 2024

Conversation

nicholaspai
Copy link
Member

No description provided.

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 2:04pm
sepolia-frontend-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 2:04pm

@nicholaspai nicholaspai marked this pull request as draft September 9, 2024 18:14
@@ -531,10 +530,6 @@ components:
description: >
The expected time (in seconds) for a fill to be made. Represents 75th percentile of the 7-day rolling average of times (updated daily). Times are dynamic by origin/destination token/chain for a given amount.
example: "4"
limits:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-a-morris @dohaki any idea how to get this to work? I want to add the TransferLimits schema as the type of limits in the SuggestedFees schema. I was following the guide here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reference this with:

limits:
    $ref: '#/components/schemas/TransferLimits'

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nicholaspai nicholaspai merged commit 43eaa2d into master Sep 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants