Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant (but also altered) rule #4052

Closed
wants to merge 1 commit into from
Closed

Conversation

mmicko
Copy link
Member

@mmicko mmicko commented Dec 5, 2023

No description provided.

@mmicko mmicko requested a review from whitequark December 5, 2023 17:31
@mmicko mmicko closed this Dec 5, 2023
@mmicko mmicko deleted the redundant_rule branch December 5, 2023 17:33
@povik
Copy link
Member

povik commented Dec 5, 2023

Ha, as it happens I just posted a fix too. Anyway I think mine is the proper fix, since we still need to make sure the techlibs/quicklogic directory exists in the build tree at the time we are generating the header.

(Only after I learned about what VPATH does in Makefiles did the linked YoWASP build failure in #4045 start to make sense.)

@povik
Copy link
Member

povik commented Dec 5, 2023

The other PR: #4053

@mmicko
Copy link
Member Author

mmicko commented Dec 5, 2023

Agree. Already asked @whitequark to take a look at your PR.

@whitequark
Copy link
Member

What the heck is VPATH.

@whitequark
Copy link
Member

Okay, I see, that's cursed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants