Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix: Poster-like date text #617

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix: Poster-like date text #617

merged 2 commits into from
Oct 22, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 22, 2024

Description

Partial for #611

Screenshots

Screen.Recording.2024-10-22.at.16.39.30.mov

Testing Instructions

  1. Create a page
  2. Add the pattern.
  3. confirm the text is like in the design.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra requested a review from carolinan October 22, 2024 14:41
@juanfra juanfra added [Type] Bug An existing feature does not function as intended. [Component] Block Patterns labels Oct 22, 2024
@juanfra juanfra requested a review from beafialho October 22, 2024 14:42
@juanfra
Copy link
Member Author

juanfra commented Oct 22, 2024

Merging this one to see if we can make it to the string freeze.

@juanfra juanfra merged commit 4c6a40f into trunk Oct 22, 2024
4 checks passed
@juanfra juanfra deleted the fix/poster-like-text branch October 22, 2024 14:47
@beafialho
Copy link
Contributor

Looking good, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Component] Block Patterns [Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants