-
Notifications
You must be signed in to change notification settings - Fork 113
update: column widths on poster-like patter #611
update: column widths on poster-like patter #611
Conversation
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Troy, it is working well to me.
Adjusting the column width is one direction that could solve it, the other direction could be adjusting the font size. I'll defer to @beafialho to pick which way to go as both changes will affect the way things look in one way or the other.
Screen.Recording.2024-10-22.at.10.30.48.mov
Thanks, I added the changes for the text here as we're almost at RC1 and we have the string freeze (hoping that we can make it). |
Too late to get this in before the freeze now that you've taken care of the date issue? |
@troychaplin for RC1 yes, which is being released now. We needed to merge it ASAP, as RC1 comes with hard string freeze. This means that strings should be ready for translators at this point. We can merge these changes now and include them for RC2 next week. You can check the entire release schedule here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, and Bea confirmed design looks well. Thanks Troy!
Description
This PR addresses #606 by changing the column widths to 80 and 20 in both instances of the block to allow for the larger font size in the example to properly fit at larger widths
Screenshots
Testing Instructions