Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

update: column widths on poster-like patter #611

Merged

Conversation

troychaplin
Copy link
Contributor

Description

This PR addresses #606 by changing the column widths to 80 and 20 in both instances of the block to allow for the larger font size in the example to properly fit at larger widths

Screenshots

example

Testing Instructions

  1. Create new page
  2. Add "Poster-like" pattern
  3. Save and view front end at more than 1900px wide (I tested at 2056)

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 21, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra requested a review from beafialho October 22, 2024 08:28
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Troy, it is working well to me.

Adjusting the column width is one direction that could solve it, the other direction could be adjusting the font size. I'll defer to @beafialho to pick which way to go as both changes will affect the way things look in one way or the other.

Screen.Recording.2024-10-22.at.10.30.48.mov

@beafialho
Copy link
Contributor

Thank you, these changes are looking good.

One comment, where I'm seeing "Mon, Jan 1" on the top right corner, should be written "Aug 08—10 2025 Fuego Bar, Mexico City", like the designs:

Captura de ecrã 2024-10-22, às 15 22 39

@juanfra
Copy link
Member

juanfra commented Oct 22, 2024

Thanks, I added the changes for the text here as we're almost at RC1 and we have the string freeze (hoping that we can make it).

@troychaplin
Copy link
Contributor Author

Thanks, I added the changes for the text here as we're almost at RC1 and we have the string freeze (hoping that we can make it).

Too late to get this in before the freeze now that you've taken care of the date issue?

@juanfra
Copy link
Member

juanfra commented Oct 22, 2024

@troychaplin for RC1 yes, which is being released now. We needed to merge it ASAP, as RC1 comes with hard string freeze. This means that strings should be ready for translators at this point. We can merge these changes now and include them for RC2 next week.

You can check the entire release schedule here.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and Bea confirmed design looks well. Thanks Troy!

@juanfra juanfra merged commit 715ad7d into WordPress:trunk Oct 22, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants