Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Add proper hover styling to links #616

Merged
merged 7 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions patterns/hidden-written-by.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
<!-- wp:paragraph -->
<p><?php esc_html_e( 'Written by ', 'twentytwentyfive' ); ?></p>
<!-- /wp:paragraph -->
<!-- wp:post-author-name {"isLink":true,"style":{"typography":{"textDecoration":"underline"}}} /-->
<!-- wp:post-author-name {"isLink":true} /-->
<!-- wp:paragraph -->
<p><?php esc_html_e( 'in', 'twentytwentyfive' ); ?></p>
<!-- /wp:paragraph -->
<!-- wp:post-terms {"term":"category","style":{"typography":{"fontWeight":"300","textDecoration":"underline"}}} /-->
<!-- wp:post-terms {"term":"category","style":{"typography":{"fontWeight":"300"}}} /-->
</div>
<!-- /wp:group -->
2 changes: 1 addition & 1 deletion patterns/template-single-left-aligned-content.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<!-- wp:paragraph -->
<p><?php echo esc_html_x( 'by', 'Prefix before the author name. The post author name is displayed in a separate block.', 'twentytwentyfive' ); ?></p>
<!-- /wp:paragraph -->
<!-- wp:post-author-name {"isLink":true,"style":{"typography":{"textDecoration":"underline"}},"fontSize":"small"} /-->
<!-- wp:post-author-name {"isLink":true,"fontSize":"small"} /-->
</div>
<!-- /wp:group -->
</div>
Expand Down
24 changes: 0 additions & 24 deletions styles/03-dusk.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,6 @@
"link": {
"color": {
"text": "var:preset|color|accent-2"
},
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
Expand All @@ -110,14 +102,6 @@
"link": {
"color": {
"text": "var:preset|color|accent-2"
},
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
Expand Down Expand Up @@ -259,14 +243,6 @@
"radius": "4px",
"width": "0.8px",
"style": "solid"
},
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
Expand Down
16 changes: 0 additions & 16 deletions styles/06-morning.json
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,6 @@
"link": {
"color": {
"text": "var:preset|color|contrast"
},
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
Expand Down Expand Up @@ -260,14 +252,6 @@
"border": {
"radius": "100px",
"color": "var:preset|color|accent-5"
},
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
Expand Down
24 changes: 0 additions & 24 deletions styles/07-sunrise.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,6 @@
"link": {
"color": {
"text": "var:preset|color|contrast"
},
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
Expand All @@ -101,14 +93,6 @@
"link": {
"color": {
"text": "var:preset|color|contrast"
},
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
Expand Down Expand Up @@ -233,14 +217,6 @@
"border": {
"radius": "100px",
"color": "var:preset|color|accent-5"
},
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
Expand Down
8 changes: 7 additions & 1 deletion styles/blocks/post-terms-1.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@
},
"typography": {
"fontWeight": "400",
"lineHeight": "2.8"
"lineHeight": "2.8",
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
Expand Down
40 changes: 0 additions & 40 deletions styles/typography/typography-preset-2.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,35 +14,11 @@
"core/post-author-name": {
"typography": {
"fontWeight": "300"
},
"elements": {
"link": {
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
},
"core/post-terms": {
"typography": {
"fontWeight": "300"
},
"elements": {
"link": {
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
},
"core/post-title": {
Expand Down Expand Up @@ -125,22 +101,6 @@
"letterSpacing": "-0.48px"
}
}
},
"variations": {
"post-terms-1": {
"elements": {
"link": {
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
}
}
}
}
26 changes: 0 additions & 26 deletions styles/typography/typography-preset-5.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,20 +62,6 @@
"fontSize": "1.25rem"
}
},
"core/post-author-name": {
"elements": {
"link": {
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
},
"core/post-title": {
"typography": {
"fontWeight": "900",
Expand Down Expand Up @@ -150,18 +136,6 @@
"post-terms-1": {
"typography": {
"fontSize": "var:preset|font-size|medium"
},
"elements": {
"link": {
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
}
}
Expand Down
38 changes: 0 additions & 38 deletions styles/typography/typography-preset-6.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,35 +16,9 @@
"fontSize": "1.25rem"
}
},
"core/post-author-name": {
"elements": {
"link": {
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
},
"core/post-terms": {
"typography": {
"fontWeight": "400"
},
"elements": {
"link": {
"typography": {
"textDecoration": "underline"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
},
"core/post-title": {
Expand Down Expand Up @@ -117,18 +91,6 @@
"post-terms-1": {
"typography": {
"fontSize": "16px"
},
"elements": {
"link": {
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
}
}
Expand Down
31 changes: 5 additions & 26 deletions theme.json
Original file line number Diff line number Diff line change
Expand Up @@ -1120,20 +1120,6 @@
"fontSize": "var:preset|font-size|medium"
}
},
"core/post-author-name": {
"elements": {
"link": {
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
},
"core/post-date": {
"color":{
"text": "var:preset|color|accent-4"
Expand Down Expand Up @@ -1167,18 +1153,6 @@
"typography": {
"fontSize": "var:preset|font-size|small",
"fontWeight": "600"
},
"elements": {
"link": {
"typography": {
"textDecoration": "none"
},
":hover": {
"typography": {
"textDecoration": "underline"
}
}
}
}
},
"core/post-title": {
Expand Down Expand Up @@ -1450,6 +1424,11 @@
"link": {
"color": {
"text": "currentColor"
},
":hover": {
"typography": {
"textDecoration": "none"
}
}
}
}
Expand Down
Loading