Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Add proper hover styling to links #616

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Add proper hover styling to links #616

merged 7 commits into from
Oct 22, 2024

Conversation

richtabor
Copy link
Member

Description

Fixes #612. Ensures there is a visual state change with link changes.

Screenshots

CleanShot.2024-10-22.at.12.57.48.mp4

Testing Instructions

Test links in post content and anywhere throughout templates.

@richtabor richtabor requested a review from juanfra October 22, 2024 10:59
@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: richtabor <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra mentioned this pull request Oct 22, 2024
Closed
@richtabor richtabor requested a review from carolinan October 22, 2024 15:23
juanfra
juanfra approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rich! Code looks good and it works well to me. Bea also confirmed that it works as intended.

@juanfra juanfra merged commit 680de05 into trunk Oct 22, 2024
5 checks passed
@juanfra juanfra deleted the try/links branch October 22, 2024 16:15
@beafialho beafialho mentioned this pull request Oct 30, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juanfra juanfra juanfra approved these changes

@carolinan carolinan Awaiting requested review from carolinan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link underline thickness inconsistency across post terms and author
2 participants
@richtabor @juanfra