[CURA-11379] Fix Prime-Tower position for printers with explicit disallowed areas. #17421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nozzle offsets can inflience the disallowed areas, so they should be taken into account for the prime-tower position. part of CURA-11379
These machines have disallowed areas (either 'machine_disallowed_areas' or 'nozzle_dissalowed_areas'), which can't at the moment be calculated with formula's (not without adding a feature at least, but we're currently in feature-freeze). part of CURA-11379
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -137,6 +137,7 @@ | |||
| "machine_start_gcode": { "value": "\"\" if machine_gcode_flavor == \"UltiGCode\" else \"G21 ;metric values\\nG90 ;absolute positioning\\nM82 ;set extruder to absolute mode\\nM107 ;start with the fan off\\nM200 D0 T0 ;reset filament diameter\\nM200 D0 T1\\nG28 Z0; home all\\nG28 X0 Y0\\nG0 Z20 F2400 ;move the platform to 20mm\\nG92 E0\\nM190 S{material_bed_temperature_layer_0}\\nM109 T0 S{material_standby_temperature, 0}\\nM109 T1 S{material_print_temperature_layer_0, 1}\\nM104 T0 S{material_print_temperature_layer_0, 0}\\nT1 ; move to the 2th head\\nG0 Z20 F2400\\nG92 E-7.0 ;prime distance\\nG1 E0 F45 ;purge nozzle\\nG1 E-5.1 F1500 ; retract\\nG1 X90 Z0.01 F5000 ; move away from the prime poop\\nG1 X50 F9000\\nG0 Z20 F2400\\nT0 ; move to the first head\\nM104 T1 S{material_standby_temperature, 1}\\nG0 Z20 F2400\\nM104 T{initial_extruder_nr} S{material_print_temperature_layer_0, initial_extruder_nr}\\nG92 E-7.0\\nG1 E0 F45 ;purge nozzle\\nG1 X60 Z0.01 F5000 ; move away from the prime poop\\nG1 X20 F9000\\nM400 ;finish all moves\\nG92 E0\\n;end of startup sequence\\n\"" }, | |||
| "machine_use_extruder_offset_to_offset_coords": { "default_value": false }, | |||
| "machine_width": { "default_value": 223 }, | |||
| "prime_tower_position_y": { "value": "170" }, | |||
| "retraction_amount": { "default_value": 5.1 }, | |||
| "retraction_speed": { "default_value": 25 }, | |||
| "speed_support": { "value": "speed_wall_0" }, | |||
There was a problem hiding this comment.
Overriding speed_support with the same value (value: speed_wall_0) as defined in parent definition: ultimaker2_plus
Suggested change
| "speed_support": { "value": "speed_wall_0" }, | |
resources/definitions/dxu.def.json
Outdated
| @@ -131,6 +131,7 @@ | |||
| "machine_width": { "default_value": 238 }, | |||
| "material_adhesion_tendency": { "enabled": true }, | |||
| "material_diameter": { "default_value": 1.75 }, | |||
| "prime_tower_position_x": { "value": "200" }, | |||
| "retraction_amount": { "default_value": 6.5 }, | |||
| "retraction_speed": { "default_value": 25 }, | |||
| "speed_support": { "value": "speed_wall_0" }, | |||
There was a problem hiding this comment.
Overriding speed_support with the same value (value: speed_wall_0) as defined in parent definition: ultimaker2_plus
Suggested change
| "speed_support": { "value": "speed_wall_0" }, | |
done as part of CURA-11379
| "retraction_amount": { "default_value": 5.1 }, | ||
| "retraction_speed": { "default_value": 25 }, | ||
| "speed_support": { "value": "speed_wall_0" }, | ||
| "speed_wall_x": { "value": "speed_wall" }, |
There was a problem hiding this comment.
Overriding speed_wall_x with the same value (value: speed_wall) as defined in parent definition: ultimaker2_plus
Suggested change
| "speed_wall_x": { "value": "speed_wall" }, | |
resources/definitions/dxu.def.json
Outdated
| "retraction_amount": { "default_value": 6.5 }, | ||
| "retraction_speed": { "default_value": 25 }, | ||
| "speed_support": { "value": "speed_wall_0" }, | ||
| "speed_wall_x": { "value": "speed_wall" }, |
There was a problem hiding this comment.
Overriding speed_wall_x with the same value (value: speed_wall) as defined in parent definition: ultimaker2_plus
Suggested change
| "speed_wall_x": { "value": "speed_wall" }, | |
done as part of CURA-11379
casperlamboo
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to to this entirely by formulas (and one other improvement is added to that in this PR), but the disallowed areas (
machine_disallowed_areasandnozzle_disallowed_areas) can be of arbitrary (well, polygonal) shape, so adding those properly will require a feature.Yet this needs to be fixed in the current release-branch. Since there are only a few printers where this is an actual problem, just fix them manually for now.