Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added per-motor control to thunderscope diagnostics. (new) #3423

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Muxite
Copy link

@Muxite Muxite commented Jan 25, 2025

Description

Added per motor control as a set of radio buttons in thunderscope diagnostic. Direct velocity and per motor control will switch depending on which radio button is pressed. The two control widgets will not appear at the same time, since both inputs are not allowed at the same time. Pressing the button for per-motor control will shut off direct-velocity control and reset those sliders, then switch the widget for per-motor control. Vice versa also applies.

Testing Done

It was tested on a robot in the mezz on Jan 25th. Test was made on all sliders of direct-velocity, switching to per-motor without using reset, changing sliders on per-motor, and switching back to direct-velocity. Back-and-forth was done twice. The robot did all the commands it was told to on all motors. It was also tested using print() on the terminal.

Resolved Issues

resolves #3320

Length Justification and Key Files to Review

drive_and_dribbler_widget.py
Added functions similar to existing ones, but that apply to per-motor controls as opposed to direct-velocity controls. Also added an enum for the control mode.

Review Checklist

This PR was reviewed before, but since it was a long time ago, I decided to make a new branch instead of resolving all the merge conflicts on the old one.

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Muxite Muxite changed the title Added per-motor control to thunderscope diagnostics. Added per-motor control to thunderscope diagnostics. (new) Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement per-motor robot control in Thunderscope
1 participant