Draw Virtual Obstacles #3406
Draw Virtual Obstacles #3406
Conversation
Mr-Anyone
requested review from
itsarune,
williamckha and
sauravbanna
as code owners
|
Also, highly likely that the code is buggy. |
…t_Software into obstacles_drawing_pr
…t_Software into obstacles_drawing_pr
src/software/thunderscope/gl/layers/gl_draw_polygon_obstacle.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/layers/gl_draw_polygon_obstacle.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/layers/gl_draw_polygon_obstacle.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/layers/gl_draw_polygon_obstacle.py
Outdated
Show resolved
Hide resolved
src/software/thunderscope/gl/layers/gl_draw_polygon_obstacle.py
Outdated
Show resolved
Hide resolved
| # TODO: as of current, this layer only supports two layers, but | ||
| # it can be easily extended to support multiple layers in the future |
There was a problem hiding this comment.
TODO should be tagged with a github issue
| from software.thunderscope.gl.widgets.gl_toolbar import GLToolbar | ||
|
|
||
|
|
||
| class ShiftButtonToolbar(GLToolbar): |
There was a problem hiding this comment.
I find this UI very confusing. Rather than a drop-down menu, it might be better as a push button where pushing the button in enables shift-click and the depressed button disables shift-click.
Also, I wonder if there are other ideas on this that @williamckha or @sauravbanna can suggest
Co-authored-by: itsarune <[email protected]>
Co-authored-by: itsarune <[email protected]>
…t_Software into obstacles_drawing_pr
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
| @@ -218,3 +222,67 @@ def set_speed_callback(self, callback: Callable[[float], None]) -> None: | |||
| :param callback: the callback function to update the simulation speed | |||
| """ | |||
| self.speed_callback = callback | |||
|
|
|||
|
|
|||
| class RandomToolbar(GLToolbar): | |||
| print("I just did something") | ||
|
|
||
|
|
||
| # TODO: move this into a different layer in the future. |
There was a problem hiding this comment.
resolve TODO or make a new GitHub issue
There was a problem hiding this comment.
I thought about it again. I think the toggle between the shift+click selecting between ball movement and virtual obstacle creation should be two buttons that are part of the toolbar on the right side of the screen.
Then, we don't need the F1, F2 thing because I'm finding the current controls hard to figure out
|
So are we still keeping the ability to switch between toolbars? |
Description
Have the ability to draw virtual obstacles. I think this is terrible UI design but it works for now. The way you use this is that you shift click to add points of a polygon. By pressing
q, the polygon is saved to the stack, so you can create a new polygon by shift clicking again. Pressingwwould remove all the polygon.I am not sure what the most user friendly way to draw these obstacles, so please give some feedback.
See below for a video of this
Testing Done
I am going to maybe write a sensor fusion test some time later?
Also, I am probably going to field test test to see if it can avoid virtual obstacles in real life.
Resolved Issues
resolves #3367
Added virtual obstacles for testing and visualization purposes.
Length Justification and Key Files to Review
N/A
See the entire video here:
Screencast from 2024-11-11 06:01:02 PM.webm
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue