Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password manager to detect password field on the login page #7500

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

PavelJankoski
Copy link
Contributor

Summary

References #7498

Changes

  • Set sensitive prop on the password form field on login screen.

Testing

Steps

Check if 1password shows up when password field is focused on login page.

Results

1password should appear to give suggestions when the field is focused.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@PavelJankoski PavelJankoski added the bug Something isn't working label Feb 4, 2025
@PavelJankoski PavelJankoski self-assigned this Feb 4, 2025
@PavelJankoski PavelJankoski requested a review from a team as a code owner February 4, 2025 14:28
@github-actions github-actions bot added the ui/web This is related to a web interface label Feb 4, 2025
@PavelJankoski PavelJankoski linked an issue Feb 4, 2025 that may be closed by this pull request
6 tasks
@PavelJankoski PavelJankoski merged commit 54b495c into v3.34 Feb 5, 2025
11 of 13 checks passed
@PavelJankoski PavelJankoski deleted the fix/7498-password-sensitive branch February 5, 2025 11:17
@KrishnaIyer KrishnaIyer added this to the v3.34.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password manager no longer auto fills
3 participants