Password manager no longer auto fills

[virtualguy]

Summary

Password manager (1password) no longer detects the password field on the login page

Steps to Reproduce

Browse to login page with password manager extension installed

Current Result

No prompt for password to be filled

Expected Result

Password auto fills

Relevant Logs

URL

No response

Deployment

The Things Stack Enterprise (self-hosted)

The Things Stack Version

No response

Client Name and Version

Other Information

This looks to have been intentionally changed by @kschiffer here:

lorawan-stack/pkg/webui/components/input/index.js

Line 222 in b253e54

data-1p-ignore={!sensitive}

Proposed Fix

No response

Contributing

• I can help by doing more research.
• I can help by implementing a fix after the proposal above is approved.
• I can help by testing the fix before it's released.

Validation

• The fix is tested in a staging environment.
• The fix is documented in The Things Stack Documentation

Code of Conduct

• I agree to follow TTN's Community Code of Conduct.

[kschiffer]

Some context: this change was added to prevent inputs for sensitive data such as JoinEUIs from showing the password manager overlays, if this also prevents password inputs from showing the overlays (even though they don't explicitly set the sensitive prop) then that was not intended.

[KrishnaIyer]

@PavelJankoski: Can you take a look?

@virtualguy Kevin does not work with us anymore. For future issues, please don't tag members directly. Github automatically adds the needs/triage label for all new issues and we have an internal process to triage them.

[johanstokking]

I think we need to split the definition of sensitive then: passwords should be filled, but root keys shouldn't, for example.