Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German localization fixes and improvements #2536

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

German localization fixes and improvements #2536

wants to merge 4 commits into from

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Nov 6, 2024

German localization fixes and improvements

Authored by dmgreeny

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related labels Nov 6, 2024
Copy link
Collaborator Author

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of edits need to be reverted. Please move edits that can be bundled with other language edits, where it makes sense, into separate changes.

@@ -97879,7 +97879,7 @@ END
// unused
CONTROLBAR:Tank_TooltipUpgradeChinaNuclearTanks
US: "+25% Emperor and Battlemaster speed"
DE: "Battlemaster und Overlords sind 25% schneller."
DE: "Battlemaster und Emperor sind 25% schneller."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The the same wording style from CONTROLBAR:TooltipUpgradeChinaFusionReactors

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wording style is not consistent.

DE: "Emperor Overlord und Battlemaster-Panzer sind 25% schneller."
DE: "Verbessert die Geschwindigkeit von Emperor Overlord und Battlemaster-Panzer."

You can for example write

DE: "Verbessert die Geschwindigkeit von Emperor Overlord und Battlemaster-Panzer um 25%."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator Author

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like something went wrong with text search and replace.

@@ -4014,7 +4014,7 @@ END
// context: Button to use the selected map
GUI:SelectAMap
US: "SELECT MAP"
DE: "Karte wählen"
DE: "Karte Wähle"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -4030,7 +4030,7 @@ END
// context: Button to go to the game selection screen
GUI:SelectAGame
US: "SELECT GAME"
DE: "Spiel wählen"
DE: "Spiel Wähle"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -4224,7 +4224,7 @@ END
GUI:Campaign
US: "CAMPAIGN"
DE: "Kampagne"
FR: "CAMPAGNE"
FR: "Campagne"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -5175,7 +5175,7 @@ END
//"Cast vote to remove player"
TOOLTIP:Vote
US: "Click to vote player out of game in order for you to continue"
DE: "Spieler aus dem Spiel wählen, um fortzufahren."
DE: "Spieler aus dem Spiel Wähle, um fortzufahren."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -5260,7 +5260,7 @@ END
// context:Used to indicate map starting locations
TOOLTIP:StartLocation
US: "Starting position"
DE: "Startposition. Klicke, um diese als deine Startposition auf der Karte auszuwählen."
DE: "Startposition. Klicke, um diese als deine Startposition auf der Karte auszuWähle."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -61314,7 +61316,7 @@ END

DIALOGEVENT:EvaGLA_IncomingDaisyCutterSubtitle
US: "*Be on alert. A Daisy Cutter bomb may be approaching"
DE: "*Be on alert. A Daisy Cutter bomb may be approaching"
DE: "*Be on alert, A Daisy Cutter bomb may be approaching"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed to comma?

@@ -61329,7 +61331,7 @@ END

DIALOGEVENT:EvaGLA_IncomingEmpPulseSubtitle
US: "*Be on alert. An EMP Pulse bomb may be approaching"
DE: "*Be on alert. An EMP Pulse bomb may be approaching"
DE: "*Be on alert, An EMP Pulse bomb may be approaching"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed to comma?

@@ -61344,7 +61346,7 @@ END

DIALOGEVENT:EvaGLA_IncomingFuelAirBombSubtitle
US: "*Be on alert. A fuel-Air bomb may be approaching"
DE: "*Be on alert. A fuel-Air bomb may be approaching"
DE: "*Be on alert, A fuel-Air bomb may be approaching"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this changed to comma?

@@ -101220,7 +101222,7 @@ END
// context: Tooltip displayed when the user mouses over the Streak 3 battle honor icon
TOOLTIP:BattleHonorStreak3Disabled
US: ""
DE: "Siegesmedaille\nFür diese Auszeichnung musst du 3 Spiele in Folge gewinnen."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

@@ -101236,7 +101238,7 @@ END
// context: Tooltip displayed when the user mouses over the Blitz battle honor icon
TOOLTIP:BattleHonorBlitz10Disabled
US: ""
DE: "Blitzkrieg-Orden\nGewinne in 10 Minuten (oder schneller) gegen Computergegner!"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed?

Copy link

@r0b2g1t r0b2g1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the review by @xezon

@@ -14107,7 +14107,7 @@ END
// context: Command to Select Team X
GUI:SelectTeam9
US: "Select Team 9"
DE: "Team 9 wählen"
DE: "Team 9 Wähle"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

@@ -14075,7 +14075,7 @@ END
// context: Command to Select Team X
GUI:SelectTeam8
US: "Select Team 8"
DE: "Team 8 wählen"
DE: "Team 8 Wähle"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

@@ -14043,7 +14043,7 @@ END
// context: Command to Select Team X
GUI:SelectTeam7
US: "Select Team 7"
DE: "Team 7 wählen"
DE: "Team 7 Wähle"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

@dmgreeny
Copy link
Collaborator

dmgreeny commented Mar 4, 2025

All comments were addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Severity: Minor < Major < Critical < Blocker Text Is text, string, localization related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants