Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/knapsack appshell #2421

Merged
merged 6 commits into from
Feb 20, 2025
+36 −4
Merged

Fix/knapsack appshell #2421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
36e4f53
fix(knapsack): app-shell styling in knapsack
owilliams320 Feb 13, 2025
4e7bef8
fix(knapsack): app-shell styling in knapsack
owilliams320 Feb 13, 2025
29bc936
build(knapsack): fix the test stage
owilliams320 Feb 19, 2025
6ba0108
build(knapsack): fix the test stage
owilliams320 Feb 19, 2025
02975fc
build(knapsack): fix the test stage
owilliams320 Feb 19, 2025
55bb35a
feat(knapsack): add new demo for outlined button
owilliams320 Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions apps/knapsack/data/demos/demo.E5ymzzEPs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
{
"id": "E5ymzzEPs",
"title": "Outlined",
"type": "data",
"patternId": "button",
"templateId": "web-components-raE1x4tYL",
"data": {
"props": {
"label": "Label",
"trailingIcon": true,
"raised": false,
"unelevated": false,
"outlined": true,
"dense": false,
"disabled": false,
"expandContent": false,
"fullwidth": false,
"icon": "add"
},
"slots": {}
}
}
2 changes: 2 additions & 0 deletions apps/knapsack/public/ks-overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,6 @@ html {
cv-app-shell {
display: block;
margin: -8px;
height: 100vh;
width: 100vw;
}
16 changes: 12 additions & 4 deletions libs/components/src/app-shell/app-shell.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@
/* Desktop only styles */
@media only screen and (min-width: 768px) {
position: fixed;
top: 0;
left: 0;
bottom: 0;
right: 0;
width: 100%;
}

Expand All @@ -92,7 +96,9 @@
height: 100vh;
grid-area: main;
overflow: auto;
transition: margin-left 200ms ease-in-out, margin-right 200ms ease-in-out;
transition:
margin-left 200ms ease-in-out,
margin-right 200ms ease-in-out;

.main-wrapper {
margin: 0 auto;
Expand Down Expand Up @@ -266,7 +272,7 @@ nav.navigation {
background-color: var(--mdc-theme-background);
z-index: var(
--cv-app-shell-navigation-z-index,
2
6
); // must be greater than --cv-app-shell-user-menu-z-index

.toggle-drawer {
Expand Down Expand Up @@ -317,8 +323,10 @@ nav.navigation {
}

.cov-drawer--hovered & {
box-shadow: 0 11px 15px -7px rgba(0, 0, 0, 20%),
0 24px 38px 3px rgba(0, 0, 0, 14%), 0 9px 46px 8px rgba(0, 0, 0, 12%);
box-shadow:
0 11px 15px -7px rgba(0, 0, 0, 20%),
0 24px 38px 3px rgba(0, 0, 0, 14%),
0 9px 46px 8px rgba(0, 0, 0, 12%);
background-color: var(--mdc-theme-surface);
}
}
Expand Down
Loading