Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/knapsack appshell #2421

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/knapsack appshell #2421

wants to merge 2 commits into from

Conversation

owilliams320
Copy link
Collaborator

Description

Adjusting the styles of our app shell component to render correctly in a knapsack example

What's included?

  • small style adjustments to app shell
  • small addition to ks-overrides.css
  • removed unused package in package.json

Test Steps

  • npm run knapsack
  • then go to the URL provided by the terminal
  • finally go to the app shell page under components and test the app shell component

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Before

Screenshot 2025-02-13 at 11 29 17 AM

After

Screenshot 2025-02-13 at 11 32 20 AM

@owilliams320 owilliams320 requested a review from adamnel February 13, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants