[Tool] Fix main build #55684
Merged
[Tool] Fix main build #55684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `main` branch build fails because of `glog` as follows: ```sh thirdparty/src/glog-0.7.1 make: *** No targets specified and no makefile found. Stop. ``` The issue is `CMAKE_GENERATOR` is set to `Ninja` but it tries to compile with `make`. To fix it, use the `BUILD_SYSTEM` command to compile which is compatible with `CMAKE_GENERATOR`. FIX StarRocks#53383 Signed-off-by: Elmi Ahmadov <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
alvin-celerdata
approved these changes
Feb 8, 2025
kevincai
approved these changes
Feb 8, 2025
|
@Mergifyio backport branch-3.4 branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
Signed-off-by: Elmi Ahmadov <[email protected]> (cherry picked from commit 3eb9baf)
18 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
Signed-off-by: Elmi Ahmadov <[email protected]> (cherry picked from commit 3eb9baf)
18 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 8, 2025
Co-authored-by: Elmi Ahmadov <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Feb 8, 2025
Co-authored-by: Elmi Ahmadov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The
mainbranch build fails because ofglogas follows:thirdparty/src/glog-0.7.1 make: *** No targets specified and no makefile found. Stop.The issue is
CMAKE_GENERATORis set toNinjain env.sh#L111 whenninjacommand is available but it tries to compile withmake.What I'm doing:
To fix it, use the command set by
BUILD_SYSTEMto compile which is compatible withCMAKE_GENERATOR.Fixes #53383
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: