Skip to content

Commit

Permalink
[Build] Fix main build
Browse files Browse the repository at this point in the history
The `main` branch build fails because of `glog` as follows:
```sh
thirdparty/src/glog-0.7.1
make: *** No targets specified and no makefile found. Stop.
```

The issue is `CMAKE_GENERATOR` is set to `Ninja` but it tries to compile
with `make`. To fix it, use the `BUILD_SYSTEM` command to compile which
is compatible with `CMAKE_GENERATOR`.

FIX #53383

Signed-off-by: Elmi Ahmadov <[email protected]
  • Loading branch information
ahmadov committed Feb 7, 2025
1 parent e9229b0 commit 3699b65
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions thirdparty/build-thirdparty.sh
Original file line number Diff line number Diff line change
Expand Up @@ -370,8 +370,8 @@ build_glog() {

$CMAKE_CMD -G "${CMAKE_GENERATOR}" -DCMAKE_INSTALL_PREFIX=$TP_INSTALL_DIR -DBUILD_SHARED_LIBS=OFF -DCMAKE_POSITION_INDEPENDENT_CODE=ON -DCMAKE_INSTALL_LIBDIR=lib

make -j$PARALLEL
make install
${BUILD_SYSTEM} -j$PARALLEL
${BUILD_SYSTEM} install
}

# gtest
Expand Down

0 comments on commit 3699b65

Please sign in to comment.