Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] ensure the latch can be counted down (backport #54859) #54913

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 10, 2025

  • latch may not be countdown due to threadpool abortion
  • add cleaner to the runnable task, ensure the countdown is ticked when the task is destroyed

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/9033

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit e267ea0)

# Conflicts:
#	be/src/service/service_be/lake_service.cpp
#	be/src/util/threadpool.h
#	be/test/util/threadpool_test.cpp
@mergify mergify bot added the conflicts label Jan 10, 2025
Copy link
Contributor Author

mergify bot commented Jan 10, 2025

Cherry-pick of e267ea0 has failed:

On branch mergify/bp/branch-3.3/pr-54859
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit e267ea0c38.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/util/threadpool.cpp
	modified:   be/test/service/lake_service_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/service/service_be/lake_service.cpp
	both modified:   be/src/util/threadpool.h
	both modified:   be/test/util/threadpool_test.cpp

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jan 10, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled January 10, 2025 04:00

Pull request was closed

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai reopened this Jan 10, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 10, 2025 06:23
@wanpengfei-git wanpengfei-git merged commit 876fa11 into branch-3.3 Jan 10, 2025
40 of 41 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-54859 branch January 10, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants