Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] ensure the latch can be counted down #54859

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[BugFix] ensure the latch can be counted down #54859

merged 1 commit into from
Jan 10, 2025
+426 −239

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Jan 9, 2025

  • latch may not be countdown due to threadpool abortion
  • add cleaner to the runnable task, ensure the countdown is ticked when the task is destroyed

Why I'm doing:

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/9033

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai kevincai requested a review from a team as a code owner January 9, 2025 03:31
@kevincai kevincai force-pushed the lake_service_exit_hang branch 4 times, most recently from 769f5b7 to 82153f6 Compare January 9, 2025 13:26
@kevincai
[BugFix] ensure the latch can be counted down
44b2001 
* latch may not be countdown due to threadpool abortion
* add cleaner to the runnable task, ensure the countdown is ticked when
  the task is destroyed

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai force-pushed the lake_service_exit_hang branch from 82153f6 to 44b2001 Compare January 9, 2025 13:40
kevincai
kevincai commented Jan 10, 2025
View reviewed changes
be/src/service/service_be/lake_service.cpp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review will be much easier with whitespace ignored option. Not much code logic change in this file.

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 156 / 193 (80.83%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/service/service_be/lake_service.cpp 142 179 79.33% [198, 199, 225, 226, 622, 623, 624, 625, 626, 629, 630, 631, 632, 633, 683, 684, 685, 695, 746, 747, 748, 749, 750, 751, 753, 754, 755, 777, 778, 779, 780, 781, 782, 784, 785, 786, 890]
🔵 be/src/util/threadpool.h 4 4 100.00% []
🔵 be/src/util/threadpool.cpp 10 10 100.00% []

@dirtysalt dirtysalt merged commit e267ea0 into StarRocks:main Jan 10, 2025
53 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 10, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 10, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jan 10, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 10, 2025
@kevincai @mergify
[BugFix] ensure the latch can be counted down (#54859)
4dbf2ef 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit e267ea0)

# Conflicts:
#	be/src/service/service_be/lake_service.cpp
@mergify mergify bot mentioned this pull request Jan 10, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
@kevincai @mergify
[BugFix] ensure the latch can be counted down (#54859)
de46d70 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit e267ea0)

# Conflicts:
#	be/src/service/service_be/lake_service.cpp
#	be/src/util/threadpool.h
#	be/test/util/threadpool_test.cpp
mergify bot pushed a commit that referenced this pull request Jan 10, 2025
@kevincai @mergify
[BugFix] ensure the latch can be counted down (#54859)
4a102b6 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit e267ea0)

# Conflicts:
#	be/src/service/service_be/lake_service.cpp
#	be/src/util/threadpool.h
#	be/test/service/lake_service_test.cpp
#	be/test/util/threadpool_test.cpp
This was referenced Jan 10, 2025
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Jan 10, 2025
@mergify @kevincai
[BugFix] ensure the latch can be counted down (backport #54859) (#54912)
35a7b89 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 10, 2025
@mergify @kevincai
[BugFix] ensure the latch can be counted down (backport #54859) (#54913)
876fa11 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 10, 2025
@mergify @kevincai
[BugFix] ensure the latch can be counted down (backport #54859) (#54914)
80b1bdd 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@dirtysalt dirtysalt dirtysalt approved these changes

@wyb wyb wyb approved these changes

Assignees

@kevincai kevincai

Labels
3.2-merged 3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevincai @wyb @dirtysalt @trueeyu