Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix transaction stream load lock leak (backport #53564) #53608

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 5, 2024

Why I'm doing:

In transaction stream load, a normal load request needs to go through the on_header, on_chunk_data, and handle processes of the TransactionStreamLoadAction. To prevent concurrent load requests, a lock will be acquired in on_header, and released in handle. But for an abnormal load request, handle may be not called, and the lock will not be released. For example, the client crashes after transmitting a part of data, only on_header and on_chunk_data are called, and handle will not be called. This can lead to resources not being cleaned up after the load timeout because the cleanup needs acquire the lock (see TransactionMgr::_clean_stream_context).

What I'm doing:

Move the lock release to TransactionStreamLoadAction::free_handler_ctx which will be always called regardless of whether an exception occurs or not.

Fixes #53155

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

Why I'm doing:

In transaction stream load, a normal load request needs to go through the on_header, on_chunk_data, and handle processes of the TransactionStreamLoadAction. To prevent concurrent load requests, a lock will be acquired in on_header, and released in handle. But for an abnormal load request, handle may be not called, and the lock will not be released. For example, the client crashes after transmitting a part of data, only on_header and on_chunk_data are called, and handle will not be called. This can lead to resources not being cleaned up after the load timeout because the cleanup needs acquire the lock (see TransactionMgr::_clean_stream_context).

What I'm doing:

Move the lock release to TransactionStreamLoadAction::free_handler_ctx which will be always called regardless of whether an exception occurs or not.

Fixes #53155

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: PengFei Li <[email protected]>
(cherry picked from commit 82fffc3)
@wanpengfei-git wanpengfei-git merged commit a8ca9f8 into branch-3.3 Dec 6, 2024
26 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-53564 branch December 6, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants