[BugFix] Fix transaction stream load lock leak #53564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
Signed-off-by: PengFei Li <[email protected]>
banmoy
force-pushed
the
txn_stream_load_lock
branch
from
96cae2e to
1493631
Compare
kevincai
reviewed
Dec 5, 2024
| } | ||
|
|
||
| void TransactionStreamLoadAction::free_handler_ctx(void* param) { | ||
| StreamLoadContext* ctx = (StreamLoadContext*)param; |
|
|
||
| void TransactionStreamLoadAction::free_handler_ctx(void* param) { | ||
| StreamLoadContext* ctx = (StreamLoadContext*)param; | ||
| if (ctx == nullptr) { |
There was a problem hiding this comment.
shall check nullptr against param before convert to StreamLoadContext?
There was a problem hiding this comment.
static_cast can be applied to nullptr so it's safe to check after the cast
Signed-off-by: PengFei Li <[email protected]>
kevincai
approved these changes
Dec 5, 2024
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 16 / 19 (84.21%) file detail
|
wyb
approved these changes
Dec 5, 2024
|
@Mergifyio backport branch-3.4 |
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]> (cherry picked from commit 82fffc3)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]> (cherry picked from commit 82fffc3) # Conflicts: # be/test/http/transaction_stream_load_test.cpp
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]> (cherry picked from commit 82fffc3) # Conflicts: # be/test/http/transaction_stream_load_test.cpp
42 tasks
|
ignore backport check: 3.1.16 |
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]>
This was referenced Dec 5, 2024
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]>
banmoy
added a commit
to banmoy/starrocks
that referenced
this pull request
Dec 5, 2024
Signed-off-by: PengFei Li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 6, 2024
) Co-authored-by: PengFei Li <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Dec 6, 2024
) Signed-off-by: PengFei Li <[email protected]> Co-authored-by: PengFei Li <[email protected]>
wyb
pushed a commit
that referenced
this pull request
Dec 6, 2024
) Signed-off-by: PengFei Li <[email protected]>
wyb
pushed a commit
that referenced
this pull request
Dec 6, 2024
) Signed-off-by: PengFei Li <[email protected]>
24 tasks
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In transaction stream load, a normal load request needs to go through the
on_header,on_chunk_data, andhandleprocesses of theTransactionStreamLoadAction. To prevent concurrent load requests, a lock will be acquired inon_header, and released inhandle. But for an abnormal load request,handlemay be not called, and the lock will not be released. For example, the client crashes before transmitting all of data, onlyon_headerandon_chunk_dataare called, andhandlewill not be called. This can lead to resources not being cleaned up after the load timeout because the cleanup needs acquire the lock (see TransactionMgr::_clean_stream_context).What I'm doing:
Move the lock release to
TransactionStreamLoadAction::free_handler_ctxwhich will be always called regardless of whether an exception occurs or not.Fixes #53155
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: