Introduce SpeziValidation #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 73.33% 77.29% +3.97%
==========================================
Files 21 34 +13
Lines 686 1061 +375
==========================================
+ Hits 503 820 +317
- Misses 183 241 +58
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Nice, great start here @Supereg 🚀 |
1 task
PSchmiedmayer
approved these changes
Nov 5, 2023
1 task
Supereg
added a commit
that referenced
this pull request
Nov 6, 2023
# Add PersonalInfo and Validation to SPI documentation targets ## ♻️ Current situation & Problem #20 and #21 introduced additional documentation targets. This PR adds them to the spi.yml such that the Swift Package Index properly builds them. ## ⚙️ Release Notes * Configured new documentation targets to be exported to SPI. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Supereg
added a commit
to StanfordSpezi/SpeziAccount
that referenced
this pull request
Nov 6, 2023
# Move to SpeziValidation package ## ♻️ Current situation & Problem Currently, SpeziAccount contains a lot of code that is not specific to account management. One part is input validation. StanfordSpezi/SpeziViews#21 introduces the new `SpeziValidation` library, based on previous code in SpeziAccount. This PR makes the efforts to move to that new software package and greatly simplify the `SpeziAccount` code base. ## ⚙️ Release Notes * Update to `SpeziValidation`, a new one-stop software package for input validation ## 📚 Documentation Documentation was addressed where needed. _TBA_: Some documentation still requires external links once the SpeziViews PR is merged. ## ✅ Testing Tests were adapted where needed. Nothing new was added. ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce SpeziValidation
♻️ Current situation & Problem
SpeziAccount currently implements a lot of logic around input validation that can easily separated into its own, self-contained target. This PR factors out those validation-based components and moves them into a new target in SpeziViews: SpeziValidation. This includes models to build
ValidationRules and views likeVerifiableTextFieldthat automatically perform validation on their input (given it's configured in the environment) and display potential validation errors.Would recommend to visit the nicely structured documentation for a great overview of the different components :)
⚙️ Release Notes
Breaking Changes
onTapFocusmodifiers were replaced by a new, simple to usefocusOnTap()modifier that doesn't require passing in a FocusState anymore.📚 Documentation
Components coming from SpeziAccount were already documented in great detail. This PR created the respective string catalog and structured all new files within a new SPM target.
✅ Testing
Appropriate UI testing was added.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: