-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to SpeziValidation package #35
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 76.01% 76.42% +0.42%
==========================================
Files 122 114 -8
Lines 4417 3952 -465
==========================================
- Hits 3357 3020 -337
+ Misses 1060 932 -128
Continue to review full report in Codecov by Sentry.
|
This PR still misses some external link to the latest SpeziViews documentation once StanfordSpezi/SpeziViews#21 is merged and tagged. And of course updating the Package.swift file to the new release version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the changes and great to see Spezi Validation in action!
Looked over the PR and it looks great. Addressing the last PRs and pulling in the latest version of SpeziViews sounds good and I am happy to see the PR being merged 🚀
Sources/SpeziAccount/AccountService/Configuration/FieldValidationRules.swift
Outdated
Show resolved
Hide resolved
Thank you @Supereg! 🚀 |
Move to SpeziValidation package
♻️ Current situation & Problem
Currently, SpeziAccount contains a lot of code that is not specific to account management. One part is input validation. StanfordSpezi/SpeziViews#21 introduces the new
SpeziValidation
library, based on previous code in SpeziAccount. This PR makes the efforts to move to that new software package and greatly simplify theSpeziAccount
code base.⚙️ Release Notes
SpeziValidation
, a new one-stop software package for input validation📚 Documentation
Documentation was addressed where needed.
TBA: Some documentation still requires external links once the SpeziViews PR is merged.
✅ Testing
Tests were adapted where needed. Nothing new was added.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: