Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to SpeziValidation package #35

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 4, 2023

Move to SpeziValidation package

♻️ Current situation & Problem

Currently, SpeziAccount contains a lot of code that is not specific to account management. One part is input validation. StanfordSpezi/SpeziViews#21 introduces the new SpeziValidation library, based on previous code in SpeziAccount. This PR makes the efforts to move to that new software package and greatly simplify the SpeziAccount code base.

⚙️ Release Notes

  • Update to SpeziValidation, a new one-stop software package for input validation

📚 Documentation

Documentation was addressed where needed.

TBA: Some documentation still requires external links once the SpeziViews PR is merged.

✅ Testing

Tests were adapted where needed. Nothing new was added.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #35 (98dbd95) into main (9bd4e0a) will increase coverage by 0.42%.
The diff coverage is 98.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   76.01%   76.42%   +0.42%     
==========================================
  Files         122      114       -8     
  Lines        4417     3952     -465     
==========================================
- Hits         3357     3020     -337     
+ Misses       1060      932     -128     
Files Coverage Δ
Sources/SpeziAccount/AccountHeader.swift 0.00% <ø> (ø)
...ce/Configuration/AccountServiceConfiguration.swift 100.00% <ø> (ø)
...ntService/Configuration/FieldValidationRules.swift 81.09% <100.00%> (+1.09%) ⬆️
...ccount/AccountService/Wrapper/StandardBacked.swift 72.10% <ø> (ø)
Sources/SpeziAccount/AccountSetup.swift 72.50% <100.00%> (ø)
Sources/SpeziAccount/AccountValue/AccountKey.swift 54.55% <ø> (-5.45%) ⬇️
...eziAccount/AccountValue/AccountValuesBuilder.swift 85.33% <100.00%> (+1.99%) ⬆️
...ountValue/Configuration/ConfiguredAccountKey.swift 63.16% <ø> (ø)
...eziAccount/AccountValue/Keys/EmailAddressKey.swift 0.00% <ø> (ø)
...s/SpeziAccount/AccountValue/Keys/PasswordKey.swift 81.25% <100.00%> (-4.79%) ⬇️
... and 24 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bd4e0a...98dbd95. Read the comment docs.

@Supereg Supereg marked this pull request as ready for review November 5, 2023 22:05
@Supereg Supereg requested a review from PSchmiedmayer November 5, 2023 22:05
@Supereg
Copy link
Member Author

Supereg commented Nov 5, 2023

This PR still misses some external link to the latest SpeziViews documentation once StanfordSpezi/SpeziViews#21 is merged and tagged. And of course updating the Package.swift file to the new release version.
Other than that, the PR is ready to review.

Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the changes and great to see Spezi Validation in action!

Looked over the PR and it looks great. Addressing the last PRs and pulling in the latest version of SpeziViews sounds good and I am happy to see the PR being merged 🚀

@Supereg Supereg merged commit 5bbeed7 into main Nov 6, 2023
7 checks passed
@Supereg Supereg deleted the feature/validation-migration branch November 6, 2023 19:02
@PSchmiedmayer
Copy link
Member

Thank you @Supereg! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants