Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/symptoms categories info naming #130 #132

Merged
merged 16 commits into from
Nov 3, 2024

Conversation

Basler182
Copy link
Contributor

symptoms adjustments

♻️ Current situation & Problem

#130

⚙️ Release Notes

  • The title and selection in the symptom dropdown have always been identical on Android. Now, as with iOS, the title is more detailed than the selection
  • the value adjustments have been made
  • completed the symptom description

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 19.51220% with 66 lines in your changes missing coverage. Please review.

Project coverage is 39.49%. Comparing base (33caec4) to head (f7aacef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../health/symptoms/SymptomsDescriptionBottomSheet.kt 0.00% 53 Missing ⚠️
...ord/bdh/engagehf/health/symptoms/SymptomsScreen.kt 0.00% 12 Missing ⚠️
...nford/bdh/engagehf/navigation/screens/AppScreen.kt 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #132      +/-   ##
============================================
+ Coverage     39.48%   39.49%   +0.02%     
- Complexity      768      784      +16     
============================================
  Files           264      265       +1     
  Lines         10431    10494      +63     
  Branches       1466     1473       +7     
============================================
+ Hits           4118     4144      +26     
- Misses         5949     5989      +40     
+ Partials        364      361       -3     
Flag Coverage Δ
uitests 33.57% <ø> (ø)
unittests 33.32% <19.52%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dh/engagehf/bluetooth/component/AppScreenEvents.kt 14.29% <ø> (ø)
.../engagehf/health/symptoms/SymptomsUiStateMapper.kt 95.29% <100.00%> (+11.61%) ⬆️
.../bdh/engagehf/health/symptoms/SymptomsViewModel.kt 89.78% <100.00%> (+1.68%) ⬆️
.../engagehf/navigation/screens/AppScreenViewModel.kt 89.56% <100.00%> (+0.16%) ⬆️
...nford/bdh/engagehf/navigation/screens/AppScreen.kt 0.00% <0.00%> (ø)
...ord/bdh/engagehf/health/symptoms/SymptomsScreen.kt 0.00% <0.00%> (ø)
.../health/symptoms/SymptomsDescriptionBottomSheet.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33caec4...f7aacef. Read the comment docs.

@Basler182 Basler182 self-assigned this Oct 26, 2024
@Basler182 Basler182 added enhancement New feature or request ENGAGE HF ENGAGE-HF-specific issues labels Oct 26, 2024
@Basler182 Basler182 linked an issue Oct 26, 2024 that may be closed by this pull request
1 task
@Basler182 Basler182 marked this pull request as ready for review October 27, 2024 10:59
@Basler182 Basler182 requested a review from eldcn October 27, 2024 11:00
@Basler182 Basler182 merged commit dc72363 into main Nov 3, 2024
11 checks passed
@Basler182 Basler182 deleted the task/symptoms-categories-info-naming-#130 branch November 3, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENGAGE HF ENGAGE-HF-specific issues enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heart Health Symptoms Score Categories Naming
2 participants