-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes for the FirebaseAccountService #43
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 66.61% 66.76% +0.15%
==========================================
Files 19 19
Lines 1087 1176 +89
==========================================
+ Hits 724 785 +61
- Misses 363 391 +28
Continue to review full report in Codecov by Sentry.
|
Thank you for adding this @Supereg! |
…y name and make external storage a batch request
Several fixes for the FirebaseAccountService
♻️ Current situation & Problem
This PR introduces several improvements for the FirebaseAccountService and fixes some bugs and issues.
We fixed an issue where the initial account would not be associated correctly and the following stateDidChange call would always be ignored independent if the state actually changed between the initial check and the call.
Further, we made minor changes to make sure that no user account is associated when we try to login or signup for a new user account. We previously always relied on the stateDidChange change handler to be called to complete operations like signup/signin/logout/delete. These operations now no longer rely on the stateDidChange listener to be called and instead always propagate their changes themselves.
⚙️ Release Notes
📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: