Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Several fixes for the FirebaseAccountService (#43)
# Several fixes for the FirebaseAccountService ## ♻️ Current situation & Problem This PR introduces several improvements for the FirebaseAccountService and fixes some bugs and issues. We fixed an issue where the initial account would not be associated correctly and the following stateDidChange call would always be ignored independent if the state actually changed between the initial check and the call. Further, we made minor changes to make sure that no user account is associated when we try to login or signup for a new user account. We previously always relied on the stateDidChange change handler to be called to complete operations like signup/signin/logout/delete. These operations now no longer rely on the stateDidChange listener to be called and instead always propagate their changes themselves. ## ⚙️ Release Notes * Fixed an issue where the initial account wouldn't be associated properly and all future state changes would be ignored until logout. * Handle existing user accounts on signIn and signUp request to be generally more robust against erroneous states. * Do not always rely on the stateDidChange handler to be called. * Added additional logging output. ## 📚 Documentation -- ## ✅ Testing -- ## 📝 Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
- Loading branch information