Skip to content
Pull Request

Adding support for Sign In with Apple #52

Sign in to view logs

Adding support for Sign In with Apple

Adding support for Sign In with Apple #52

Triggered via pull request October 21, 2023 02:05
@SuperegSupereg
synchronize #18
feature/apple-single-sign-on
Status Failure
Total duration 33s
Artifacts –
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

pull_request.yml

on: pull_request
REUSE Compliance Check  /  ...  /  REUSE Compliance Check
12s
REUSE Compliance Check / REUSE Compliance Check / REUSE Compliance Check
SwiftLint  /  ...  /  SwiftLint
22s
SwiftLint / SwiftLint / SwiftLint
Fit to window
Zoom out
Zoom in

Annotations

10 errors
SwiftLint / SwiftLint / SwiftLint: Tests/UITests/TestApp/Shared/TestAppDelegate.swift#L25
Line Length Violation: Line should be 150 characters or less; currently it has 153 characters (line_length)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L51
Todo Violation: TODOs should be resolved (provider enum instantiation?) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L53
Todo Violation: TODOs should be resolved (source name from type) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L63
Todo Violation: TODOs should be resolved (move both somewhere else!) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L68
Todo Violation: TODOs should be resolved (something better? => crypto gr...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L97
Todo Violation: TODOs should be resolved (reauthenticate token https://f...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L122
Todo Violation: TODOs should be resolved (token revocation!!! https://fi...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/Account Services/FirebaseIdentityProviderAccountService.swift#L188
Todo Violation: TODOs should be resolved (we are currently bypassing all...) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/FirebaseAccountConfiguration.swift#L67
Todo Violation: TODOs should be resolved (pass apple in here?) (todo)
SwiftLint / SwiftLint / SwiftLint: Sources/SpeziFirebaseAccount/IdentityProvider/FirebaseSignInWithAppleButton.swift#L25
Todo Violation: TODOs should be resolved (do we need to control the labe...) (todo)