-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Sign In with Apple #18
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
- Coverage 62.41% 59.14% -3.26%
==========================================
Files 10 17 +7
Lines 641 1023 +382
==========================================
+ Hits 400 605 +205
- Misses 241 418 +177
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks great as discussed in the meeting!
Adding support for Sign In with Apple
♻️ Current situation & Problem
Currently, we only support email- and password-based authentication using Firebase. This PR makes the first step to add single sign on providers by adding support for Sign in with Apple.
⚙️ Release Notes
📚 Documentation
Documentation was adjusted were required.
✅ Testing
Testing was added where possible. As we cannot rely reliably test Sign in with Apple, the Firebase Identity Provider Account Service is not fully tested autonomously.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: