Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Sign In with Apple #18

Merged
merged 14 commits into from
Oct 23, 2023
Merged

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Oct 18, 2023

Adding support for Sign In with Apple

♻️ Current situation & Problem

Currently, we only support email- and password-based authentication using Firebase. This PR makes the first step to add single sign on providers by adding support for Sign in with Apple.

⚙️ Release Notes

  • Add support for Sign In with Apple

📚 Documentation

Documentation was adjusted were required.

✅ Testing

Testing was added where possible. As we cannot rely reliably test Sign in with Apple, the Firebase Identity Provider Account Service is not fully tested autonomously.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #18 (b87cb0e) into main (56dd7fb) will decrease coverage by 3.26%.
The diff coverage is 68.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
- Coverage   62.41%   59.14%   -3.26%     
==========================================
  Files          10       17       +7     
  Lines         641     1023     +382     
==========================================
+ Hits          400      605     +205     
- Misses        241      418     +177     
Files Coverage Δ
...count/AccountValues/FirebaseEmailVerifiedKey.swift 0.00% <ø> (ø)
...FirebaseAccount/FirebaseAccountConfiguration.swift 100.00% <100.00%> (ø)
...aseAccount/FirebaseAuthAuthenticationMethods.swift 100.00% <ø> (ø)
...urces/SpeziFirebaseAccount/Utils/CryptoUtils.swift 95.00% <95.00%> (ø)
...ccount/Account Services/FirebaseAccountError.swift 67.11% <50.00%> (ø)
...irebaseAccount/Views/FirebaseAccountModifier.swift 90.91% <90.91%> (ø)
...eAccount/Views/FirebaseSignInWithAppleButton.swift 70.38% <70.38%> (ø)
...Services/FirebaseEmailPasswordAccountService.swift 90.39% <90.39%> (ø)
...ount/Account Services/FirebaseAccountService.swift 79.27% <79.27%> (ø)
...s/SpeziFirebaseAccount/Utils/FirebaseContext.swift 91.99% <91.99%> (ø)
... and 2 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56dd7fb...b87cb0e. Read the comment docs.

@PSchmiedmayer PSchmiedmayer mentioned this pull request Oct 18, 2023
1 task
@Supereg Supereg marked this pull request as ready for review October 23, 2023 06:18
@Supereg Supereg requested a review from PSchmiedmayer October 23, 2023 07:31
Package.swift Show resolved Hide resolved
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great as discussed in the meeting!

@Supereg Supereg merged commit 774c5e3 into main Oct 23, 2023
7 checks passed
@Supereg Supereg deleted the feature/apple-single-sign-on branch October 23, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants