Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[choreolib] Added more triggers #1159

Merged
merged 24 commits into from
Jan 29, 2025
Merged

[choreolib] Added more triggers #1159

merged 24 commits into from
Jan 29, 2025

Conversation

oh-yes-0-fps
Copy link
Collaborator

No description provided.

shueja
shueja previously requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@shueja shueja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be merged until we root-cause #1161.

choreolib/src/main/java/choreo/auto/AutoRoutine.java Outdated Show resolved Hide resolved
choreolib/src/main/java/choreo/auto/AutoTrajectory.java Outdated Show resolved Hide resolved
@Daniel1464
Copy link
Contributor

Maybe add a chain(Command, AutoTrajectory) overload? If that isnt clear enough you can call it thenRun instead of chain.

Also you should document it too.

@katzuv
Copy link
Contributor

katzuv commented Jan 21, 2025 •
edited
Loading

Is it possible to add done() and doneFor() overloads that take time? And basically multiply the time by 50.

@oh-yes-0-fps oh-yes-0-fps enabled auto-merge (squash) January 23, 2025 04:18
@oh-yes-0-fps oh-yes-0-fps requested a review from shueja January 23, 2025 05:02
@oh-yes-0-fps oh-yes-0-fps merged commit 1f68147 into SleipnirGroup:main Jan 29, 2025
34 checks passed
calcmogul pushed a commit to calcmogul/Choreo that referenced this pull request Jan 30, 2025
@oh-yes-0-fps @calcmogul
[choreolib] Added more triggers (SleipnirGroup#1159)
905ff6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty approved these changes

@shueja shueja Awaiting requested review from shueja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oh-yes-0-fps @Daniel1464 @katzuv @shueja @spacey-sooty