Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Splitting Surrogates #213

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Stop Splitting Surrogates #213

merged 2 commits into from
Nov 14, 2019

Conversation

theck13
Copy link
Contributor

@theck13 theck13 commented Nov 14, 2019

Fix

This is the Android counterpart of Simperium/node-simperium#91 and Simperium/simperium-ios#582. These changes stop the splitting of surrogate pairs, which resulted in corrupted data in note content.

Review

Only one developer is required to review these changes, but anyone can perform the review.

@theck13 theck13 added the Bug label Nov 14, 2019
@theck13 theck13 requested a review from dmsnell November 14, 2019 19:03
Copy link
Contributor

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patching this. In testing this gave us the notes we wanted.

Do we have a beta channel to get this out into testing before sending it to everyone?

@theck13
Copy link
Contributor Author

theck13 commented Nov 14, 2019

When we update the com.simperium.android:simperium dependency in Simplenote, it will be included in the next code freeze. Following the code freeze, Simplenote will be released to our beta testers where they can test for two weeks before we release to everyone.

@theck13 theck13 merged commit cb41a1f into develop Nov 14, 2019
@theck13 theck13 deleted the stop-splitting-surrogates branch November 14, 2019 21:13
@theck13 theck13 mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants