Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Splitting Surrogates #882

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Stop Splitting Surrogates #882

merged 1 commit into from
Nov 15, 2019

Conversation

theck13
Copy link
Contributor

@theck13 theck13 commented Nov 15, 2019

Fix

Update the simperium dependency, which includes changes to stop the splitting of surrogate pairs that resulted in corrupted data in note content as described in Simperium/simperium-android#213.

Test

  1. Tap New note floating action button.
  2. Insert 🙂🙁 in note.
  3. Insert 😱 between 🙂 and 🙁 in note.
  4. Notice emojis appear as 🙂😱🙁 in note.
  5. Tap back arrow in top app bar.
  6. Notice emojis appear as 🙂😱🙁 in note list.
  7. Tap note from Step 1.
  8. Notice emojis appear as 🙂😱🙁 in note.

Review

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@theck13 theck13 added this to the 2.3 milestone Nov 15, 2019
@peril-automattic
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@AmandaRiu AmandaRiu self-assigned this Nov 15, 2019
dmsnell
dmsnell approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

AmandaRiu
AmandaRiu approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly :shipit:

@AmandaRiu AmandaRiu merged commit 6c6ffaf into develop Nov 15, 2019
@AmandaRiu AmandaRiu removed their assignment Nov 15, 2019
@AmandaRiu AmandaRiu deleted the stop-splitting-surrogates branch November 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmsnell dmsnell dmsnell approved these changes

@AmandaRiu AmandaRiu AmandaRiu approved these changes

@mchowning mchowning Awaiting requested review from mchowning

@anitaa1990 anitaa1990 Awaiting requested review from anitaa1990

Assignees
No one assigned
Labels
[Type] Bug Something isn't working.
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
3 participants
@theck13 @dmsnell @AmandaRiu