Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Nova Code Editor Ext manifest #4389

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
6 changes: 6 additions & 0 deletions src/api/json/catalog.json
Original file line number Diff line number Diff line change
Expand Up @@ -3679,6 +3679,12 @@
"fileMatch": ["notebook.mod.json"],
"url": "https://raw.githubusercontent.com/BookkeepersMC/notebook-schemas/master/notebook.mod.json/schemas/main.json"
},
{
"name": "Nova Editor",
"description": "Nova Editor Extension Manifest",
"fileMatch": ["**/*.novaextension/extension.json", "extension.json"],
"url": "https://json.schemastore.org/extension.json"
},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @madskristensen. Unfortunately the name they chose is very generic inherently. However I did forgot to add *.novaextension/ folder, which I just did

{
"name": "NOX Framework (Service)",
"description": "NOX service definition",
Expand Down
13 changes: 13 additions & 0 deletions src/negative_test/extension/incorrect-debug-adaptor.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"bugs": "https://example.com/debug-issues",
"categories": ["issues"],
"debugAdapters": {
"identifier": "debug.helper.adapter",
"name": "Debug Helper Adapter"
},
"description": "An extension with debug support.",
"identifier": "com.example.debug-helper",
"name": "Debug Helper",
"organization": "Debug Tools Ltd.",
"version": "1.1.0"
}
10 changes: 10 additions & 0 deletions src/negative_test/extension/invalid-activation-events.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"activationEvents": "onStart",
"bugs": "https://example.com/issues",
"categories": ["Utilities"],
"description": "An example with invalid activation events.",
"identifier": "com.example.invalid-activation",
"name": "Invalid Activation Events",
"organization": "Example Org",
"version": "1.0.0"
}
9 changes: 9 additions & 0 deletions src/negative_test/extension/invalid-url.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"bugs": "not-a-valid-url",
"categories": ["Utilities"],
"description": "An example with invalid URLs.",
"identifier": "com.example.invalid-url",
"name": "Invalid URL",
"organization": "Example Org",
"version": "1.0.0"
}
9 changes: 9 additions & 0 deletions src/negative_test/extension/invalid-version.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"bugs": "not-a-valid-url",
"categories": ["Utilities"],
"description": "An example with invalid URLs.",
"identifier": "com.example.invalid-url",
"name": "Invalid URL",
"organization": "Example Org",
"version": "1.0.0"
}
3 changes: 3 additions & 0 deletions src/negative_test/extension/missing-required-fields.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"name": "Missing Required Fields"
}
9 changes: 9 additions & 0 deletions src/negative_test/extension/unrecognised-category.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"bugs": "https://example.com/issues",
"categories": ["Utilities"],
"description": "A basic valid extension.",
"identifier": "com.example.basic-extension",
"name": "Basic Extension",
"organization": "Example Corp",
"version": "1.0.0"
}
15 changes: 15 additions & 0 deletions src/negative_test/extension/wrong-type.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"bugs": "https://example.com/debug-issues",
"categories": ["issues"],
"debugAdapters": [
{
"identifier": "debug.helper.adapter",
"name": "Debug Helper Adapter"
}
],
"description": "An extension with debug support.",
"identifier": "com.example.debug-helper",
"name": "Debug Helper",
"organization": "Debug Tools Ltd.",
"version": "1.1.0"
}
Loading