added support for Nova Code Editor Ext manifest #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
src/api/json/catalog.json
Outdated
| { | ||
| "name": "Nova Editor", | ||
| "description": "Nova Editor Extension Manifest", | ||
| "fileMatch": ["extension.json"], |
There was a problem hiding this comment.
This is a bit generic. Can you add a more specific pattern like a folder name as well?
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
EmranMR
commented
Jan 27, 2025
| "description": "Nova Editor Extension Manifest", | ||
| "fileMatch": ["**/*.novaextension/extension.json", "extension.json"], | ||
| "url": "https://json.schemastore.org/extension.json" | ||
| }, |
There was a problem hiding this comment.
Hi @madskristensen. Unfortunately the name they chose is very generic inherently. However I did forgot to add *.novaextension/ folder, which I just did
|
@EmranMR Thanks for the update! I'll be able to merge this if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This should add support for the
extension.jsonmanifest, used by Nova Code editor for extension development.Below is the link to the manifest for you:
Thanks
Emran