Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sage): import shiny-base project #2939

Merged
merged 66 commits into from
Dec 7, 2024

Conversation

tschaffter
Copy link
Member

@tschaffter tschaffter commented Dec 7, 2024

Changelog

Note

The repo was imported using nx import {repo url}. This method conserves the Git history of the source repo.

Preview

Build the Docker image

Inside the monorepo:

nx build-image sage-shiny-base

Lint the Dockerfile

The Dockerfile is linted automatically with Hadolint when committing files (locally) and when pushing commits to GitHub (workflow, see Checks below).

The monorepo also has the Hadolint and SonarQube extensions for VS Code that highlight the issues.

image

Future Work

@tschaffter tschaffter marked this pull request as ready for review December 7, 2024 05:22
@tschaffter tschaffter merged commit 7849b72 into Sage-Bionetworks:main Dec 7, 2024
14 of 15 checks passed
@tschaffter tschaffter deleted the sage/shiny-base branch December 7, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants