[GEN-1313] Export detailed columns for NAACCR codes #567
Conversation
|
Close pr for now to rebuild docker image |
genie/consortium_to_public.py
Outdated
There was a problem hiding this comment.
Just a comment. Nothing actionable here. I think it's OK we don't have unit tests for these giant functions: stagingToCbio, store_clinical_files and consortiumToPublic in the database_to_staging and consortium_to_public code just because these are better tested using integration tests and we already did that with our pipeline comparisons and our test runs on the test pipeline.
Doing this would be outside the scope of this ticket and is already part of our tech debt epic to refactor and add tests.
There was a problem hiding this comment.
Yes, I agree that we add unit tests later for these functions for our tech debt epic.
There was a problem hiding this comment.
The more we can spin out "unit functions" within these larger functions, the more they will be better served as integration tests.
If we think of these as ETL, it should tell the story of data processing.
|
Problem:
Need to export detailed columns for NAACCR codes
Solution:
Add the detailed columns when corresponding race, sex, and ethnicity columns are available.
Test:
Tested locally and ran through validation and processing steps successfully with expected results.