Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-996] convert the clinical template columns from a set to a list #554

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

danlu1
Copy link
Contributor

@danlu1 danlu1 commented Mar 14, 2024

Problem:
Run into ValueError: columns cannot be a set when upgrading to pandas >= 1.5 for Clinical.preprocess

Solution:
Convert set to list

Test:
unit test function has been added

@danlu1 danlu1 requested a review from a team as a code owner March 14, 2024 22:21
@danlu1 danlu1 marked this pull request as draft March 15, 2024 17:31
@danlu1 danlu1 marked this pull request as ready for review March 18, 2024 22:24
add docstring to test function
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work, would hold off on merging

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@rxu17 rxu17 changed the title [GEN-978] convert the clinical template columns from a set to a list [GEN-996] convert the clinical template columns from a set to a list Apr 16, 2024
@rxu17 rxu17 changed the base branch from develop to gen-178-update-pandas-2 April 16, 2024 23:00
@rxu17
Copy link
Contributor

rxu17 commented Apr 16, 2024

@danlu1 Feel free to merge in this PR.

@danlu1 danlu1 merged commit eb18202 into gen-178-update-pandas-2 Apr 17, 2024
8 checks passed
@thomasyu888 thomasyu888 deleted the GEN_978_fix_column_type branch April 25, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants