-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEN-997] update method to concatenate columns for dataframe #555
[GEN-997] update method to concatenate columns for dataframe #555
Conversation
remove unused package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Had a few comments
remove unused modules
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Thanks for modularizing the code and for the great review!
🎉 All dependencies have been resolved ! |
Problem:
Cannot generate UNIQUE_KEY column by concatenating primary_cols for empty dataframe
Solution:
Special handling for empty dataframes: have them create the column directly and set it to ““
Test:
unit test function has been added
Depends on #554