Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEN-997] update method to concatenate columns for dataframe #555

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

danlu1
Copy link
Contributor

@danlu1 danlu1 commented Mar 15, 2024

Problem:
Cannot generate UNIQUE_KEY column by concatenating primary_cols for empty dataframe

Solution:
Special handling for empty dataframes: have them create the column directly and set it to ““

Test:
unit test function has been added

Depends on #554

@danlu1 danlu1 requested a review from a team as a code owner March 15, 2024 17:30
@danlu1 danlu1 marked this pull request as draft March 15, 2024 17:30
@danlu1 danlu1 marked this pull request as ready for review March 18, 2024 23:16
remove unused package
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Had a few comments

tests/test_load.py Outdated Show resolved Hide resolved
tests/test_load.py Show resolved Hide resolved
tests/test_load.py Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
19 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Thanks for modularizing the code and for the great review!

Copy link

dpulls bot commented Apr 17, 2024

🎉 All dependencies have been resolved !

@danlu1 danlu1 merged commit e2c2321 into gen-178-update-pandas-2 Apr 17, 2024
8 checks passed
@thomasyu888 thomasyu888 deleted the GEN_997_empty_df_concatenante_cols branch April 25, 2024 03:43
@thomasyu888 thomasyu888 restored the GEN_997_empty_df_concatenante_cols branch April 25, 2024 03:43
@thomasyu888 thomasyu888 deleted the GEN_997_empty_df_concatenante_cols branch April 25, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants