Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENP-2825: Automatically trigger builds on push #156

Merged
merged 7 commits into from
Jun 25, 2024

Conversation

lachlancooper
Copy link
Member

@lachlancooper lachlancooper commented Jun 24, 2024

Summary

Automatically trigger builds of all images via actions workflows on push to any branch.

If the pushed branch is the default, the images will be released using their current version tag.

This also bumps the version of all external actions to the latest.

Problem description

Currently, image builds are triggered manually and individually. This has multiple issues:

  • A branch can be broken with no feedback at PR review time.
  • Testing is manual and it's easy to miss one or more builds.
  • Releasing is manual and it's easy to miss one or more builds after merge.

Pros/cons of approach implemented

  • Removes the ability to trigger individual builds/releases manually.
    • The overall workflow can still be triggered manually if needed.
  • The base protoc image typically needs to be built and released before the individual images (e.g. protoc-cpp).
    • This workflow restricts the build to one job at a time to ensure protoc is built first.
    • This could be improved with reusable workflows, i.e. build protoc in a separate workflow to the other images.

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@lachlancooper lachlancooper changed the title ENP-2825: Automatically trigger actions ENP-2825: Automatically trigger builds on push Jun 25, 2024
@lachlancooper lachlancooper marked this pull request as ready for review June 25, 2024 01:37
@lachlancooper lachlancooper requested a review from a team as a code owner June 25, 2024 01:37
@lachlancooper lachlancooper merged commit 321b417 into main Jun 25, 2024
9 checks passed
@lachlancooper lachlancooper deleted the ENP-2825-trigger-actions branch June 25, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants