Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UT-5995] Update protoc image to latest alpine and buf version #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BCook98
Copy link
Member

@BCook98 BCook98 commented Jan 29, 2025

Summary

Pulls in the latest buf version, and also updates alpine at the same time!

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...
  • For breaking changes: I have confirmed that other repos are not affected, or I have planned a deployment sequence to address any impact.

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

Copy link
Member

@lachlancooper lachlancooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a similar change in #151 but hit issues with several builds failing, and had to revert it in #154.

(The failures were not obvious in advance back then, so I introduced auto-triggered builds in #156).

FYI I also tried bumping buf in https://github.com/SafetyCulture/APISchema/pull/4684, which introduced a whole bunch of config and formatting changes. Not blocking, but it may take some work to fully roll this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants