Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): multi input more button dropdown values #10787

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

N1XUS
Copy link
Contributor

@N1XUS N1XUS commented Oct 24, 2023

Related Issue(s)

relates #10649

Description

  • Fixed "n more" dropdown list values for core multi input
  • Docs sidebar now uses fd-scrollbar

Please check whether the PR fulfills the following requirements

During Implementation
  1. Visual Testing:
  • visual misalignments/updates
  • check Light/Dark/HCB/HCW themes
  • RTL/LTR - proper rendering and labeling
  • responsiveness(resize)
  • Content Density (Cozy/Compact/(Condensed))
  • States - hover/disabled/focused/active/on click/selected/selected hover/press state
  • Interaction/Animation - open/close, expand/collapse, add/remove, check/uncheck
  • Mouse vs. Keyboard support
  • Text Truncation
  1. API and functional correctness
  • check for console logs (warnings, errors)
  • API boundary values
  • different combinations of components - free style
  • change the API values during testing
  1. Documentation and Example validations
  • missing API documentation or it is not understandable
  • poor examples
  • Stackblitz works for all examples
  1. Accessibility testing
  2. Browser Testing - Edge, Safari, Chrome, Firefox
PR Quality

@N1XUS N1XUS added bug Something isn't working documentation There is an issue with documentation core Core library specific issues labels Oct 24, 2023
@N1XUS N1XUS added this to the Sprint 124 milestone Oct 24, 2023
@N1XUS N1XUS requested a review from a team October 24, 2023 09:03
@N1XUS N1XUS self-assigned this Oct 24, 2023
@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit cf4ac39
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6538272fa830c50008aa1d67
😎 Deploy Preview https://deploy-preview-10787--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Visit the preview URL for this PR (updated for commit cf4ac39):

https://fundamental-ngx-gh--pr10787-fix-multi-input-more-co36hxg1.web.app

(expires Fri, 27 Oct 2023 20:31:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@N1XUS N1XUS force-pushed the fix/multi-input-more-behaviour branch from 1d6f100 to 325a6fb Compare October 24, 2023 09:35
@N1XUS N1XUS force-pushed the fix/multi-input-more-behaviour branch from 325a6fb to 162c4b3 Compare October 24, 2023 12:56
@N1XUS N1XUS merged commit 738914d into main Oct 25, 2023
@N1XUS N1XUS deleted the fix/multi-input-more-behaviour branch October 25, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core library specific issues documentation There is an issue with documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants