Sprint 123 Defect hunting - Horizon Testing

[g-cheishvili]

Issues that are found during the deffect hunt

[droshev]

the hamburger menu isn't responding

[InnaAtanasova]

Multi Input Core - #10712
NOTE FROM MIKE I believe the "____ more" text is only for compact tokenizer, not cozy
In smaller screens the input should have an indication how many more items are selected but not shown. For example 5 more. In this case there's no way for the user to know how many items are selected until they open the dropdown list

FROM INNA disagree. This is a regression. We had a diferent behaviour before. You can see it here: https://sap.github.io/fundamental-ngx/#/core/multi-input

UI5 implementation:

[droshev]

Clustering the findings:

Blockers:

• Theming (to be confirmed)- Issue with Theming Service while applying theme #10700
• Theming (to be confirmed)- Theme not working properly #10628
• Theming (Icons) (to be confirmed)- Icons not rendering properly in horizon theme #10603
• Arrow is in a wrong place. Popover placement and styling removes padding in
• When you start resizing popover, it starts selecting everything that is behind
• Platform search field's category seems out of the context/ Buttons on hover jump left/right

Issues:

• Popover (to be confirmed) - Height of the popover is not according to the content. #10602

• Dynamic Page (to be confirmed) - Component Bug: Dynamic Page Sub-Header Style #10550

• Busy Indicator (to be confirmed) - Focus on the Busy Indicator inside the fd-dialog-body component #10547

• Wizard (to be confirmed) - Wizard focus and scrolling issues #10391

• Core Multi Input - on clicking the link more, we should see listed only the selected items, not all of them. In platform is correct. - fix(core): multi input more button dropdown values #10787

• Core mobile calendar: unnecessary scrollbar:
  

• Carousel: keyboard navigation works only once. After slide being changed, user needs to click on the image again in order for the navigation to work again - fix(core): various carousel fixes #10767

• Carousel loading example: Busy indicator a bit off - fix(core): various carousel fixes #10767
  

• Carousel vertical variant does not react to Arrow down and up keys, only to arrow left and right - fix(core): various carousel fixes #10767

• Dialog Resizable -

• Link: when focused, icon color is still blue:
  
  Will be fixed with fix: link focus icon color fundamental-styles#4913

• More as an improvement: Core combobox accepts TemplateRef input property for the item renderer. It's better to use structural directive here with support of typed arguments - N1XUS feat(core,platform): combobox custom templates #10785

• Pagination: when page loading is in progress, I think we should disable pagination buttons in order not to mess up the data.

• Docs sidebar has standard scrollbar. Should be fundamentals one:
  - fix(core): multi input more button dropdown values #10787

• Rating indicator docs uses native controls (inputs, selects). Should be replaced with fundamentals alternative - N1XUS

• Core select: Icon in placeholder is skewed:
  

• Time: using mousewheel is not smooth (not feeling natural). I'm assuming it does not count delta property of mousewheel efect and just moves the value up/down based on the direction of the scroll. I would suggest applying similar logic as we have with dragging - we scroll the numbers according to the deltaX of the mousewheel event;

• Core grid list keyboard navigation is not bound to the grid list container. If you arrive at the last item in any of the grid list containers and click "arrow right" it will jump to the next example component. Additionally, grid list item does not have ability to have navigation vertically. Only arrow right and arrow left work

• Drag and drop does not work on card layout

• After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element. Now it is going back to the start of the page

• Popover focusAutoCapture does not focus the first tabbable element immediately after opening

• Variant management/Smart Filter Bar spacing isn't 100% matching the visual specification

[g-cheishvili]

Something's terribly wrong with platform thumbnail and I do not know whether we should delete it or fix it => deprecated component. To be removed soon

[N1XUS]

@droshev Drag and drop does not work on card layout it's actually working, but the drag area of the card is not obvious. Need to discuss the design and user interaction logic

[N1XUS]

After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element. Now it is going back to the start of the page - checked with Dialog documentation page. Everything works as described. Could someone provide a page where this is happening?

[N1XUS]

Core mobile calendar: unnecessary scrollbar: -> is not a bug. We use size constrains in config of the dialog window:

[N1XUS]

Inline help does not look vertically centered

[droshev]

@kalo2711 Can you retest the not checked issues and document what is reproducible?

[kalo2711]

NOT fixed:

• Pagination: when page loading is in progress, I think we should disable pagination buttons in order not to mess up the data.
• Core mobile calendar: unnecessary scrollbar: (Landscape only)
• Dialog Resizable
• *** Time: using mousewheel is not smooth (not feeling natural) *** This seems good to me (buttons), the scrolling is just too accelerated.
• Core grid list keyboard navigation is not bound to the grid list container
• *** After closing/dismissing a dialog, we should be bringing the focus back to the previously focused element.*** This works when closing dialogs and doesn't reproduce the issue, but the dismissing dialog isn't compiling.
• Popover focusAutoCapture does not focus the first tabbable element immediately after opening
• Variant management/Smart Filter Bar spacing isn't 100% matching the visual specification