Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P1][Sourcing][translation] f-ngx/i18n missing some lang locales #10137

Closed
yixuan-liu opened this issue Jul 7, 2023 · 10 comments
Closed

[P1][Sourcing][translation] f-ngx/i18n missing some lang locales #10137

yixuan-liu opened this issue Jul 7, 2023 · 10 comments
Assignees
Milestone

Comments

@yixuan-liu
Copy link

yixuan-liu commented Jul 7, 2023

Is this a bug, enhancement, or feature request?

Enhancement

Briefly describe your proposal.

F-NGX/i18n is missing some locales that Guided Sourcing currently supports. We will need complete i18n locale support from F-NGX/i18n to cover all of our supported languages/locales.

Our complete locale list:
Languages supported by Guided Sourcing

<style> </style>
Lang (SS) Lang (SS) Lang Description(SS) F-NGx supported
bg bg_BG Bulgarian v1 
cs cs_CZ Czech  v1
da da_DK Danish  
de de_DE German
el el_GR Greek  
en en_US English
es es_ES Spanish  
fi fi_FI Finnish  
fr fr_FR French v1 
hu hu_HU Hungarian  
hr hr_HR Croatian  
it it_IT Italian  v1
ja ja_JP Japanese
ko ko_KR Korean  
nl nl_NL Dutch  
no no_NO Norwegian
pl pl_PL Polish  v1
pt pt_BR Brazilian Portuguese ✅ 
ro ro_RO Romanian  
ru ru_RU Russian  v1
sv sv_SE Swedish  
tr tr_TR Turkish  v1
zh_CN zh_CN Simplified Chinese  tbd
zh_TW zh_TW Traditional Chinese  tbd
th th_TH Thai  

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Latest version with Angular 15.

Is there anything else we should know?

Note that the eu code in our locale list stands for pseudo locale only.

@yixuan-liu yixuan-liu changed the title [Sourcing] Need complete i18n locale support [Sourcing] f-ngx/i18n not supporting all lang locales Jul 7, 2023
@yixuan-liu yixuan-liu changed the title [Sourcing] f-ngx/i18n not supporting all lang locales [Sourcing] f-ngx/i18n missing some lang locales Jul 7, 2023
@yixuan-liu yixuan-liu changed the title [Sourcing] f-ngx/i18n missing some lang locales WIP: [Sourcing] f-ngx/i18n missing some lang locales Jul 11, 2023
@fkolar
Copy link
Member

fkolar commented Jul 14, 2023

This is to discuss wtih F-NGX about the process. Currently it is based on contribution mode, whoever wants to translate they can:

  • In such case we use google translate
  • hard to validate if its correct translation
  • How we can plug them into existing SAP Localisation team process ?

@yixuan-liu
Copy link
Author

yixuan-liu commented Jul 14, 2023

This is to discuss wtih F-NGX about the process. Currently it is based on contribution mode, whoever wants to translate they can:

  • In such case we use google translate
  • hard to validate if its correct translation
  • How we can plug them into existing SAP Localisation team process ?

Thanks Frank! I remember F-NGX used to output all i18n strings using @angular/localize, and our translation team was able to pick those up in their pipeline. Any reason why F-NGX moved away from that approach?

@yixuan-liu
Copy link
Author

Hi Frank, just wanted to check in and see if we have any updates on this issue? Thanks!

@I543348
Copy link

I543348 commented Aug 22, 2023

adding @fkolar for further clarification
cc: @yixuan-liu

@rvamudha rvamudha changed the title WIP: [Sourcing] f-ngx/i18n missing some lang locales WIP: [1][Sourcing] f-ngx/i18n missing some lang locales Aug 30, 2023
@fkolar fkolar changed the title WIP: [1][Sourcing] f-ngx/i18n missing some lang locales WIP: [P1][Sourcing] f-ngx/i18n missing some lang locales Aug 31, 2023
@droshev
Copy link
Contributor

droshev commented Sep 11, 2023

there is an investigation needed how to proceed; see the translation format files and how convert that.
setup the repo for the translation system

@droshev droshev changed the title WIP: [P1][Sourcing] f-ngx/i18n missing some lang locales [P1][Sourcing] f-ngx/i18n missing some lang locales Sep 11, 2023
@droshev
Copy link
Contributor

droshev commented Sep 21, 2023

We discussed the issues where the translation of diff. languages would require multiple translations. As the translation team doesn't support that Sourcing team agrees to move with 1:1 translation(e.g. plurals), which could lead to not correct translations for all strings.

Another step would be to go with German's(de locale) translation.

@rvamudha
Copy link

Languages supported by Guided Sourcing

<style> </style>
Lang (SS) Lang (SS) Lang Description(SS) F-NGx supported
bg bg_BG Bulgarian  
cs cs_CZ Czech  
da da_DK Danish  
de de_DE German  
el el_GR Greek  
en en_US English  
es es_ES Spanish  
fi fi_FI Finnish  
fr fr_FR French  
hu hu_HU Hungarian  
hr hr_HR Croatian  
it it_IT Italian  
ja ja_JP Japanese  
ko ko_KR Korean  
nl nl_NL Dutch  
no no_NO Norwegian  
pl pl_PL Polish  
pt pt_BR Brazilian Portuguese  
ro ro_RO Romanian  
ru ru_RU Russian  
sv sv_SE Swedish  
tr tr_TR Turkish  
zh_CN zh_CN Simplified Chinese  
zh_TW zh_TW Traditional Chinese  
th th_TH Thai  

@droshev droshev changed the title [P1][Sourcing] f-ngx/i18n missing some lang locales [P1][Sourcing][translation] f-ngx/i18n missing some lang locales Sep 22, 2023
@SAP SAP deleted a comment from rvamudha Oct 11, 2023
@droshev
Copy link
Contributor

droshev commented Oct 11, 2023

German and Brazilian Portuguese are already included

@droshev
Copy link
Contributor

droshev commented Oct 25, 2023

The translation team requested all text items to have comments and prefixes:
the prefix guidelines are https://help.sap.com/saphelp_ewm92/helpdata/en/83/1039835e7c4da3a8a0b49567573afe/frameset.htm

@g-cheishvili
Copy link
Contributor

This is already in the ngx both main and ng15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants