WIP: [Med][Aug]Dynamically adding rows to the ngx-platform table - Create, Save and Cancel button labels should be externalized for translations.

[nehabeke]

Is this a bug, enhancement, or feature request?

bug

Briefly describe your proposal.

I am using ngx platfrom table - https://sap.github.io/fundamental-ngx/#/platform/table/basic
Where I am using property called [editMode]="'inline'" to add rows dynamically to the table.
This property automatically generates 3 buttons: Create, Save and Cancel. These "Create", "Save" and "Cancel" button labels are not localized properly. These strings should be externalized for translations.

Which versions of Angular and Fundamental Library for Angular are affected? (If this is a feature request, use current version.)

Angular CLI: 15.2.0
"@fundamental-ngx/core": "0.40.2-rc.8",
"@fundamental-ngx/platform": "0.40.2-rc.8",

If this is a bug, please provide steps for reproducing it.

Please provide relevant source code if applicable.

https://stackblitz.com/run?file=src%2Fmain.ts

Is there anything else we should know?

[github-actions]

Hello @nehabeke, thank you for using fundamental-ngx! The fundamental-ngx team will triage your issue as soon as possible.

[nehabeke]

Hi, Would you kindly give prompt attention to this particular issue? Please let me know If you have any questions, I will be happy to help.

[fkolar]

@nehabeke

I checked and the translation is in place

It is just some languages might not be fully translated.

• Which language is the problem here? (we can use temporary Google Translate to do this)

@mikerodonnell89, @N1XUS , there was some way a workaround where application could override some translation right?

[nehabeke]

Hi,

I have asked someone from doc team to check this. I will get back to you once I hear back from her.

Thanks,
Neha

[nehabeke]

This another bug is similar to this one, could you please take a look at this as well?
#9884

Thanks,
Neha

[N1XUS]

@fkolar @nehabeke You can patch language values by using patchLanguage provider: https://github.com/SAP/fundamental-ngx/blob/main/libs/i18n/src/lib/utils/patch-language.ts

[N1XUS]

Additionally, you can simply clone one of translation objects, rewrite the language values to your needs, and provide it as a language. Since FD_LANGUAGE is a BehaviourSubject, you can emit next value at any time you want.

[fkolar]

Hi,

I have asked someone from doc team to check this. I will get back to you once I hear back from her.

Thanks, Neha

Ok. in meanwhile we have a workaround but please get us the information what language does not have the translation. There should be no needs to provide custom translation for those buttons.

[nehabeke]

Hi, we have checked, it is not working for any of the languages.

[fkolar]

Can you double check? I see something different. in the navigation bar change the language to French for example...

https://fundamental-ngx.netlify.app/#/platform/table/basic#basic-add-rows

[fkolar]

Can you check the link I sent you? There is a table with create button. in the top right corner you can change a lang.
Also one. recommendation don't copy screenshots from internal application!

Please be informed that Issues prefixed WIP are issues in progress and they need some more work and F-NGX
will not look at them, until I will remove this prefix

[nehabeke]

It is working in the link you have provided. But not working in the application. I am not getting why. Could you please recommend any other solution for this?

[fkolar]

I would definitely check:
https://sap.github.io/fundamental-ngx/#/core/i18n
https://github.com/SAP/fundamental-ngx/blob/main/apps/docs/src/app/app.module.ts
https://github.com/SAP/fundamental-ngx/blob/main/libs/docs/core/toolbar/toolbar-docs.component.ts

Closing as this is more about how to use certain thing that can be discussed offline + there is another issue related to i18n #10137