Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): using json formats as a source for tew and added resolve utilities #10571

Merged
merged 21 commits into from
Sep 26, 2023

Conversation

g-cheishvili
Copy link
Contributor

Related Issue(s)

Part of #10137

Description

Using json language files as sources now.
Added helper functions to make translations easier now
Added and updated i18n documentation sections

BREAKING CHANGE:
Placeholders should be wrapped inside one pair of the curly braces from now on.
{{ something }} with context {something: 'value'} would become "value" before, now the same output will require { something } to be the input
Also {{{ something }}} would result in {value}, now it will throw, to have that same output, the user will have to type '{'{something}'}'

@g-cheishvili g-cheishvili added sourcing required for sourcing i18n labels Sep 19, 2023
@g-cheishvili g-cheishvili added this to the Sprint 122 milestone Sep 19, 2023
@g-cheishvili g-cheishvili requested a review from a team September 19, 2023 20:59
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 89d075c
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6512cc4462ba070008af507c
😎 Deploy Preview https://deploy-preview-10571--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Visit the preview URL for this PR (updated for commit 89d075c):

https://fundamental-ngx-gh--pr10571-10137-i18n-tew-k5hzsn1o.web.app

(expires Fri, 29 Sep 2023 12:36:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@g-cheishvili g-cheishvili changed the title feat(i18n): using json formats as a source for tew feat(i18n): using json formats as a source for tew and added resolve utilities Sep 21, 2023
@g-cheishvili g-cheishvili force-pushed the 10137-i18n-tew branch 3 times, most recently from aba286b to 3facd7d Compare September 25, 2023 15:39
Copy link
Contributor

@N1XUS N1XUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job! Just couple of minor comments

libs/docs/i18n/writing-translations.component.ts Outdated Show resolved Hide resolved
libs/i18n/src/lib/utils/load-json.ts Show resolved Hide resolved
libs/i18n/src/lib/utils/translation-resolver.ts Outdated Show resolved Hide resolved
@g-cheishvili g-cheishvili merged commit 5fa5e37 into main Sep 26, 2023
@g-cheishvili g-cheishvili deleted the 10137-i18n-tew branch September 26, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n sourcing required for sourcing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants