-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): using json formats as a source for tew and added resolve utilities #10571
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit the preview URL for this PR (updated for commit 89d075c): https://fundamental-ngx-gh--pr10571-10137-i18n-tew-k5hzsn1o.web.app (expires Fri, 29 Sep 2023 12:36:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
aba286b
to
3facd7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Just couple of minor comments
3ffa45c
to
8eecaed
Compare
Related Issue(s)
Part of #10137
Description
Using json language files as sources now.
Added helper functions to make translations easier now
Added and updated i18n documentation sections
BREAKING CHANGE:
Placeholders should be wrapped inside one pair of the curly braces from now on.
{{ something }}
with context{something: 'value'}
would become "value" before, now the same output will require{ something }
to be the inputAlso
{{{ something }}}
would result in{value}
, now it will throw, to have that same output, the user will have to type'{'{something}'}'